From f46a6c991f966156437fddb8d023cd5d5abfa131 Mon Sep 17 00:00:00 2001 From: scottrippey Date: Thu, 25 Jan 2024 15:21:31 -0600 Subject: [PATCH 1/2] feature(build): fixed build issues --- packages/groq-builder/src/commands/select$.ts | 3 ++- packages/groq-builder/tsconfig.json | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/groq-builder/src/commands/select$.ts b/packages/groq-builder/src/commands/select$.ts index fd7f6d37..5c53fa1b 100644 --- a/packages/groq-builder/src/commands/select$.ts +++ b/packages/groq-builder/src/commands/select$.ts @@ -52,7 +52,8 @@ GroqBuilder.implement({ "When using 'select', either all conditions must have validation, or none of them. " + `Missing validation: "${missing.join('", "')}"` ); - Error.captureStackTrace(err, GroqBuilder.prototype.select$); + // This only works on V8 engines: + (Error as any).captureStackTrace?.(err, GroqBuilder.prototype.select$); throw err; } diff --git a/packages/groq-builder/tsconfig.json b/packages/groq-builder/tsconfig.json index 4082f16a..d2e172c8 100644 --- a/packages/groq-builder/tsconfig.json +++ b/packages/groq-builder/tsconfig.json @@ -1,3 +1,6 @@ { - "extends": "../../tsconfig.json" + "extends": "../../tsconfig.json", + "compilerOptions": { + "target": "ES2019", + } } From b521a4a8a4fec8f7a370bb2cc984061d3ae24d14 Mon Sep 17 00:00:00 2001 From: scottrippey Date: Thu, 25 Jan 2024 15:26:16 -0600 Subject: [PATCH 2/2] feature(build): ensure groq-builder gets built in CI --- .github/workflows/static-analysis.yml | 2 ++ package.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml index 52a33a81..4aaad693 100644 --- a/.github/workflows/static-analysis.yml +++ b/.github/workflows/static-analysis.yml @@ -35,7 +35,9 @@ jobs: - name: Build library run: pnpm run build:lib + - name: Type Check run: pnpm run typecheck + - name: Lint run: pnpm run lint diff --git a/package.json b/package.json index 11798533..ae5883b8 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "typecheck:shared": "tsc --project tsconfig.shared.json --noEmit", "typecheck": "pnpm run typecheck:shared && pnpm run -r typecheck", "check:ci": "pnpm run typecheck && pnpm run lint && pnpm run test", - "build:lib": "pnpm run --filter groqd build", + "build:lib": "pnpm run --filter groqd --filter groq-builder build", "build:packages": "pnpm run --filter groqd --filter groqd-playground build", "build": "pnpm run -r build", "changeset": "changeset",