Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dealiasing should be part of the equation, not the grid #286

Open
navidcy opened this issue Jun 2, 2021 · 5 comments
Open

dealiasing should be part of the equation, not the grid #286

navidcy opened this issue Jun 2, 2021 · 5 comments

Comments

@navidcy
Copy link
Member

navidcy commented Jun 2, 2021

It makes more sense.

Yes, dealiasing is related to wavenumbers. But whether dealiasing should happened and what sort of dealiasing (2/3, 1/2, ...) depends on the order of nonlinearity that calcN! includes. So it makes more sense to make kralias, kalias, ... part of the Equation struct.

@glwagner
Copy link
Member

glwagner commented Jun 2, 2021

I think this could work.

But I'd point out that dealiasing is really not a property of a PDE, but a property of arithmetic operations between fields. With a fully-fledged field abstraction, I think dealiasing would have to be part of the grid.

@navidcy
Copy link
Member Author

navidcy commented Jun 2, 2021

Hm... OK. Dealiasing should be part of the grid. But for different equations the aliasing_factor could be different...

@navidcy
Copy link
Member Author

navidcy commented Jun 2, 2021

We'll leave this for future, not something to be done in #285.

@glwagner
Copy link
Member

glwagner commented Jun 2, 2021

I guess equations / problems might have to enforce certain grid properties?

@navidcy
Copy link
Member Author

navidcy commented Jun 2, 2021

Yes, ideally either the equation or the problem might be able to change the aliased_fraction property of the grid...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants