Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for MultiLayerQG module in GeophysicalFlows.jl v0.16 #70

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Dec 20, 2023

Closes #67

@navidcy navidcy marked this pull request as ready for review December 20, 2023 06:14
@navidcy navidcy requested a review from jbisits December 20, 2023 06:14
Copy link
Collaborator

@jbisits jbisits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Should we bump a minor release because of this change? Just to delineate between the old MultiLayerQG with density and this new version with buoyancy?

@jbisits jbisits self-requested a review December 20, 2023 09:12
@navidcy
Copy link
Member Author

navidcy commented Dec 20, 2023

It's not really a change in the API of PassiveTracer flows...

@jbisits
Copy link
Collaborator

jbisits commented Dec 20, 2023

It's not really a change in the API of PassiveTracer flows...

True. I suppose the compat for Geophysical.jl takes care of any compatibility issues anyway.

@navidcy navidcy merged commit 72c6111 into main Dec 20, 2023
5 checks passed
@navidcy navidcy deleted the ncc-jib/update-multilayerqg branch December 20, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants