Skip to content

Commit 4a3607e

Browse files
committed
More tests
1 parent 487b38e commit 4a3607e

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/DFGPass.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,17 +147,16 @@ class DFGPass(ctx: TranslationContext) : ComponentPass(ctx) {
147147
* `comprehension.statement`.
148148
*/
149149
protected fun handleCollectionComprehension(comprehension: CollectionComprehension) {
150-
if (comprehension.comprehensionExpressions.size > 1) {
150+
if (comprehension.comprehensionExpressions.isNotEmpty()) {
151151
comprehension.comprehensionExpressions
152-
.subList(0, comprehension.comprehensionExpressions.size - 2)
152+
.subList(0, comprehension.comprehensionExpressions.size - 1)
153153
.forEachIndexed { i, expr ->
154154
expr.nextDFG += comprehension.comprehensionExpressions[i + 1]
155155
}
156-
}
157-
if (comprehension.comprehensionExpressions.isNotEmpty())
158156
comprehension.statement?.let {
159157
comprehension.comprehensionExpressions.last().nextDFG += it
160158
}
159+
}
161160
comprehension.statement?.let { comprehension.prevDFG += it }
162161
}
163162

cpg-core/src/test/kotlin/de/fraunhofer/aisec/cpg/graph/edges/collections/UnwrappedEdgeListTest.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ class UnwrappedEdgeListTest {
5353
assertEquals(1, node2.prevEOGEdges.size)
5454
assertEquals(1, node3.prevEOGEdges.size)
5555
assertEquals(1, node3.prevEOG.size)
56+
57+
assertEquals(listOf<Node>(node2, node3), node1.nextEOG.subList(0, 2))
58+
assertEquals(listOf<Node>(node1), node3.prevEOG.subList(0, 1))
5659
}
5760
}
5861

0 commit comments

Comments
 (0)