Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong parameters don't write any log message #53

Open
rursprung opened this issue Dec 3, 2024 · 1 comment
Open

wrong parameters don't write any log message #53

rursprung opened this issue Dec 3, 2024 · 1 comment
Labels
enhancement Improvement to current implementation / features

Comments

@rursprung
Copy link
Contributor

rursprung commented Dec 3, 2024

i accidentally put BalanceWhiteAuto into the wrong parameter group (namely AcquisitionControl instead of AnalogControl) and spent way too long to figure out why it wasn't working.
there's no logging available which would validate the parameters.

if there's a value to be set it is being logged in debug mode:

[component_container-1] 1733258515.305053145: [camera_driver_right] [DEBUG]     Evaluating 'AcquisitionControl.ExposureAuto' for stream 0.
[component_container-1] 1733258515.305088493: [camera_driver_right] [DEBUG]     Setting 'ExposureAuto' to 'Continuous'

since all the values are evaluated manually in the code there are lots of evaluating [..] entries (and this finally helped me spot that i had the wrong group), but there's no check on the values in parameters to make sure that they're well-known.

i think it'd be beneficially if a check would be added which validates that all entries in parameters are valid and prints warnings (if not errors) in case they're not.

@boitumeloruf boitumeloruf added the enhancement Improvement to current implementation / features label Dec 5, 2024
@boitumeloruf
Copy link
Collaborator

Good idea, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to current implementation / features
Projects
None yet
Development

No branches or pull requests

2 participants