Skip to content

Husky install deprecated #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GMSoudersJr opened this issue Sep 10, 2024 · 1 comment · Fixed by #90
Closed

Husky install deprecated #89

GMSoudersJr opened this issue Sep 10, 2024 · 1 comment · Fixed by #90
Assignees

Comments

@GMSoudersJr
Copy link
Collaborator

Is this worth fixing?

image

image

So husky init isn't an option.

According to the How To Section # Manual Setup
image

Current package.json:

"scripts": {
  "prepare": "husky install",
}

Should be changed to:

"scripts": {
  "postinstall": "husky",
}

or simply:

"scripts": {
  "prepare": "husky",
}

since it seems to work fine. If not, I guess the README.md would need to be updated as well:

image

We already have this with yarn pre-commit instead

image

Thoughts...

@GMSoudersJr
Copy link
Collaborator Author

And there's more

image

@GMSoudersJr GMSoudersJr self-assigned this Sep 11, 2024
GMSoudersJr added a commit that referenced this issue Sep 11, 2024
husky install is deprecated, the documentation also said to use
postinstall instead of prepare because yarn does not support it. Updated
the README.md to mirror the script change as well.

closes #89
@GMSoudersJr GMSoudersJr linked a pull request Sep 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant