Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: libfuse2 dependency is EOL for the appimage version. #5714

Closed
3 tasks done
BeatlesNo1 opened this issue Sep 17, 2024 · 4 comments · May be fixed by #5747
Closed
3 tasks done

[Feature Request]: libfuse2 dependency is EOL for the appimage version. #5714

BeatlesNo1 opened this issue Sep 17, 2024 · 4 comments · May be fixed by #5747
Labels
E: improvement existing feature enhancement New feature or request U: duplicate This issue or pull request already exists

Comments

@BeatlesNo1
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

libfuse2 dependency is EOL for appimage version.

Proposed Solution

migration to libfuse3.

Alternatives Considered

n/a

Issue Labels

improvement to existing feature

Additional Information

No response

@absidue
Copy link
Member

absidue commented Sep 17, 2024

Duplicate of #5641

As AppImage doesn't support fuse 3, it is not possible for us to provide an AppImage that uses fuse 3, their official documentation says to install fuse 2 (linked in the provided issue).

@absidue absidue closed this as completed Sep 17, 2024
@github-actions github-actions bot added the U: duplicate This issue or pull request already exists label Sep 17, 2024
@Samueru-sama
Copy link

Duplicate of #5641

As AppImage doesn't support fuse 3, it is not possible for us to provide an AppImage that uses fuse 3, their official documentation says to install fuse 2 (linked in the provided issue).

This is actually possible and it is done by plenty of appimages already, examples include: Cemu (since like 2 years ago), duckstation, PCSX2 and Zen-browser.

Will see if I can make the PR like I just did here

The AppImage documentation is outdated, very outdated.

@absidue
Copy link
Member

absidue commented Sep 24, 2024

@Samueru-sama If you know a way of doing it that would be great!
We don't actually build the AppImage (or any of the other packages) ourselves, we call our to electron-builder and that takes care of it for us. So you'll have to make modifications to electron-builder and it's various dependencies, to change how the AppImage is built.

Probably not useful to you, but the file that invokes electron-builder is _scripts/build.js and the configuration it passes to electron-builder is in _scripts/ebuilder.config.js.

@Samueru-sama
Copy link

@Samueru-sama If you know a way of doing it that would be great! We don't actually build the AppImage (or any of the other packages) ourselves, we call our to electron-builder and that takes care of it for us. So you'll have to make modifications to electron-builder and it's various dependencies, to change how the AppImage is built.

Probably not useful to you, but the file that invokes electron-builder is _scripts/build.js and the configuration it passes to electron-builder is in _scripts/ebuilder.config.js.

I was actually asking for help understanding how the CI worked here, because I checked the workflow files and noticed that it immediately went from build to upload appimage and I was like wait what where is the rest lol so thank you for the explanation.

This means there are two ways to fix this issue.

  • A) Open an issue at electron-builder to update to a different appimagetool that automatically uses the static appimage runtime, hopefully they are using the appimagetool from AppImage/AppImageKit, because in that case there is the appimagetool from AppImage/appimagetool which is a drop in replacement that pulls the static runtime by default. AKA just change one word in the download link.

  • B) Right after the appimage gets build here, extract it and wget appimagetool and remake the appimage, it is a bit hacky but will work, this method will also allow for generating the .zsync files for delta updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: improvement existing feature enhancement New feature or request U: duplicate This issue or pull request already exists
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants