-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring and update #36
Open
FrenkyDema
wants to merge
24
commits into
main
Choose a base branch
from
refactor/fix-widgets-style
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests update
This was
linked to
issues
Sep 25, 2024
Fix icon sizeFactor
Refactoring
Refactoring Update tests
Add ButtonType to different CustomActionButton
Refactoring
Refactoring
Refactoring
Add margin to RoundedContainer
Refactoring Increase/Decrease and CustomActionButton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and Bug Fixes for Widgets:
Increment/Decrement,
Expandable List,
Custom Action Button,
and List Tile Buttons
Summary
This PR includes refactoring, improvements, and bug fixes for the following files:
increment_decrement_widget.dart
expandable_list_tile_button.dart
custom_action_button.dart
list_tile_button.dart
These changes address functional improvements, fix issues related to widget behavior, enhance UI consistency, and ensure better state management across the application.
Changes:
increment_decrement_widget.dart
:expandable_list_tile_button.dart
:custom_action_button.dart
:CustomActionButton
, especially concerning theScrollController
in aDraggableScrollableSheet
.list_tile_button.dart
:ListTileButton
andIconListTileButton
.leading
andtrailing
widgets for consistent alignment.InkWell
widget to ensure the entire button area is clickable, including padding.sizeFactor
parameter inIconListTileButton
to allow dynamic resizing of icons relative to text.ListTile
manage its own layout for better consistency and alignment.RoundedContainer
to remove unnecessary padding and margins, ensuring compatibility withMaterial
andInkWell
.Testing:
General Testing:
increment_decrement_widget.dart
Tests:expandable_list_tile_button.dart
Tests:custom_action_button.dart
Tests:onPressed
andonLongPress
callbacks function as expected.list_tile_button.dart
Tests:ListTileButton
renders correctly with all combinations ofleading
,title
,subtitle
, andtrailing
widgets.IconListTileButton
with differentsizeFactor
values to ensure icons resize properly and remain vertically centered.sizeFactor
without affecting alignment.InkWell
does not affect the visual appearance but improves interaction.Fixes:
General Fixes:
Specific Issues Addressed:
ListTileButton
andIconListTileButton
.Issues Closed:
ListTileButton
.custom_action_button.dart
.increment_decrement_widget.dart
.Files Updated:
increment_decrement_widget.dart
expandable_list_tile_button.dart
custom_action_button.dart
list_tile_button.dart
list_tile_button_test.dart
(Updated tests forListTileButton
and related widgets)