Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull before/after date #14

Open
NotQuiteApex opened this issue Jul 21, 2021 · 2 comments
Open

Pull before/after date #14

NotQuiteApex opened this issue Jul 21, 2021 · 2 comments
Assignees
@NotQuiteApex
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
1.2.0

Comments

@NotQuiteApex
Copy link
Collaborator

Twitch video and clip data has fields for times, which are simply unix timestamps and can easily be compared against.

Issues to consider include:

  • Are dates inclusive? Just before and/or after dates?
  • Relative dates? How do they work?
  • Timezones? If so, how do they get accounted for in the command? How are they accounted for in relative dates?
@NotQuiteApex NotQuiteApex self-assigned this Jul 21, 2021
@NotQuiteApex NotQuiteApex added the enhancement New feature or request label Jul 21, 2021
@NotQuiteApex NotQuiteApex added the help wanted Extra attention is needed label Aug 13, 2021
@NotQuiteApex NotQuiteApex added this to the 1.0.0 milestone Sep 21, 2021
@NotQuiteApex NotQuiteApex removed this from the 1.0.0 milestone Oct 3, 2021
@NotQuiteApex
Copy link
Collaborator Author

This seems like too open ended of a question for right now. Will return to this later.

@NotQuiteApex
Copy link
Collaborator Author

Some ideas for relative times: (would need to be relevant to the second VodBot is started)

1s = one second
2m = two minutes
3h = three hours
4d = four days
5W = five weeks
6M = six months
7Y = seven years

We should ignore timezones but make sure that times are using Unix timestamps which are meant to match GMT/UTC. Running on Windows needs to take this into account.

Absolute dates/times should be inclusive for the "after" flag, not inclusive for the "before" flag (after_time <= x < before_time). We compare against the timestamps that are provided by Twitch, which are GMT/UTC

@NotQuiteApex NotQuiteApex added this to the 1.2.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NotQuiteApex NotQuiteApex

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@NotQuiteApex