drop use of E_STRICT

Author: mentalstring

lib/plugin/sfPearEnvironment.class.php

@@ -8,8 +8,6 @@
  * file that was distributed with this source code.
  */
 
-// Remove E_STRICT from error_reporting
-error_reporting(error_reporting() & ~E_STRICT);
 date_default_timezone_set('UTC');
 
 require_once 'PEAR.php';

lib/plugins/sfDoctrinePlugin/test/functional/fixtures/apps/backend/config/settings.yml

@@ -5,15 +5,15 @@ prod:
 
 dev:
   .settings:
-    error_reporting:        <?php echo (E_ALL | E_STRICT)."\n" ?>
+    error_reporting:        <?php echo E_ALL."\n" ?>
     web_debug:              true
     cache:                  false
     no_script_name:         false
     etag:                   false
 
 test:
   .settings:
-    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_NOTICE)."\n" ?>
+    error_reporting:        <?php echo (E_ALL ^ E_NOTICE)."\n" ?>
     cache:                  false
     web_debug:              false
     no_script_name:         false

lib/plugins/sfDoctrinePlugin/test/functional/fixtures/apps/frontend/config/settings.yml

@@ -5,15 +5,15 @@ prod:
 
 dev:
   .settings:
-    error_reporting:        <?php echo (E_ALL | E_STRICT)."\n" ?>
+    error_reporting:        <?php echo E_ALL."\n" ?>
     web_debug:              true
     cache:                  false
     no_script_name:         false
     etag:                   false
 
 test:
   .settings:
-    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_NOTICE)."\n" ?>
+    error_reporting:        <?php echo (E_ALL ^ E_NOTICE)."\n" ?>
     cache:                  false
     web_debug:              false
     no_script_name:         false

lib/task/generator/skeleton/app/app/config/settings.yml

@@ -8,15 +8,15 @@ prod:
 
 dev:
   .settings:
-    error_reporting:        <?php echo (E_ALL | E_STRICT)."\n" ?>
+    error_reporting:        <?php echo E_ALL."\n" ?>
     web_debug:              true
     cache:                  false
     no_script_name:         false
     etag:                   false
 
 test:
   .settings:
-    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_NOTICE)."\n" ?>
+    error_reporting:        <?php echo (E_ALL ^ E_NOTICE)."\n" ?>
     cache:                  false
     web_debug:              false
     no_script_name:         false

lib/test/sfTestFunctionalBase.class.php

@@ -429,12 +429,6 @@ public static function handlePhpError($errno, $errstr, $errfile, $errline)
                 throw new RuntimeException($msg);
                 break;
 
-            case E_STRICT:
-                $msg = sprintf($msg, 'strict');
-
-                throw new RuntimeException($msg);
-                break;
-
             case E_RECOVERABLE_ERROR:
                 $msg = sprintf($msg, 'catchable');
 

test/functional/fixtures/apps/cache/config/settings.yml

@@ -5,17 +5,15 @@ prod:
 
 dev:
   .settings:
-    # E_ALL | E_STRICT = 4095
-    error_reporting:        4095
+    error_reporting:        30719
     web_debug:              true
     cache:                  true
     no_script_name:         false
     etag:                   true
 
 test:
   .settings:
-    # E_ALL | E_STRICT = 4095
-    error_reporting:        4095
+    error_reporting:        30719
     web_debug:              false
     cache:                  true
     no_script_name:         false

test/functional/fixtures/apps/frontend/config/settings.yml

@@ -5,15 +5,15 @@ prod:
 
 dev:
   .settings:
-    error_reporting:        <?php echo (E_ALL | E_STRICT)."\n" ?>
+    error_reporting:        <?php echo E_ALL."\n" ?>
     web_debug:              true
     cache:                  false
     no_script_name:         false
     etag:                   false
 
 test:
   .settings:
-    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_NOTICE)."\n" ?>
+    error_reporting:        <?php echo (E_ALL ^ E_NOTICE)."\n" ?>
     cache:                  false
     web_debug:              false
     no_script_name:         false

test/functional/fixtures/apps/i18n/config/settings.yml

@@ -5,15 +5,15 @@ prod:
 
 dev:
   .settings:
-    error_reporting:        <?php echo (E_ALL | E_STRICT)."\n" ?>
+    error_reporting:        <?php echo E_ALL."\n" ?>
     web_debug:              true
     cache:                  false
     no_script_name:         false
     etag:                   false
 
 test:
   .settings:
-    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_NOTICE)."\n" ?>
+    error_reporting:        <?php echo (E_ALL ^ E_NOTICE)."\n" ?>
     cache:                  false
     web_debug:              false
     no_script_name:         false

test/unit/plugin/sfPearEnvironmentTest.php

@@ -8,8 +8,6 @@
  * file that was distributed with this source code.
  */
 
-error_reporting(error_reporting() & ~E_STRICT);
-
 require_once __DIR__.'/../../bootstrap/unit.php';
 
 $t = new lime_test(3);

test/unit/plugin/sfPearRestPluginTest.php

@@ -8,8 +8,6 @@
  * file that was distributed with this source code.
  */
 
-error_reporting(error_reporting() & ~E_STRICT);
-
 require_once __DIR__.'/../../bootstrap/unit.php';
 
 $t = new lime_test(5);