Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Suggestion: Option to use native Window Controls #143

Open
Skyyblaze opened this issue May 26, 2024 · 3 comments
Open

Feature Suggestion: Option to use native Window Controls #143

Skyyblaze opened this issue May 26, 2024 · 3 comments

Comments

@Skyyblaze
Copy link

Skyyblaze commented May 26, 2024

I was looking for a new lightweight text-editor that has more functions than Editor.exe from Windows and like Fastedit very much for this purpose. I realize my feature suggestion is very niche but I wondered, could Fastedit have an option to use the native Windows window controls instead of drawing its own so it harmonizes better with custom themes?

This is how Editor looks with my theme:

grafik

And this is how Fastedit looks in comparison:

grafik

If this is not within the scope of development, I completely understand, thanks for the hard work either way!

@FrozenAssassine
Copy link
Owner

Hey, sorry for not answering for such a long time. I really lost motivation.
But guess I am back now😂

Since I am working on a rewrite for WinUI3, this should not be hard to implement.

In your screenshot you have customized the close, minimize and maximize buttons, and it seems like they are not customized in Fastedit but only in the Windows Editor. Is it really only in Fastedit or does this happen in any other apps too. Also does it work in any other App written in WinUI3 and does it not work in any other app written in UWP. Could you find this out?

@Skyyblaze
Copy link
Author

Hey, sorry for not answering for such a long time. I really lost motivation. But guess I am back now😂

Since I am working on a rewrite for WinUI3, this should not be hard to implement.

In your screenshot you have customized the close, minimize and maximize buttons, and it seems like they are not customized in Fastedit but only in the Windows Editor. Is it really only in Fastedit or does this happen in any other apps too. Also does it work in any other App written in WinUI3 and does it not work in any other app written in UWP. Could you find this out?

@FrozenAssassine No worries and sorry for the late reply too I didn't really have time to look at Github until now. Thanks for the great app and looking into this!

Well from the top of my head I can say:

Apps where the custom theme is showing:

  • Windows Terminal with the Titlebar enabled
  • Windows Editor
  • Firefox forced in Windows 7 Mode
  • Windows Explorer

Apps where the custom theme isn't showing:

  • Windows Terminal with Titlebar disabled
  • Chromium Browsers
  • Firefox with no modifications
  • Fastedit
  • UWP Games / Apps

what are some WinUI 3 apps I could test to help you? From my understanding for the custom theme to show the app has to take its titlebar and buttons from the .msstyles file in Windows instead of drawing its own.

@FrozenAssassine
Copy link
Owner

Thanks for the information, now I added a setting to show the default window titlebar. This is at the moment the only option. So I guess it now works the same as in Windows Terminal.

In your screenshots from earlier Windows Editor even shows the tabs and your custom theme without the additional titlebar like in my screenshot below. But I don't know how to archive this currently.

Can you link or share your custom theme for me to test around a bit?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants