From 66434b425b6c6d04c96b10d05aa8b32be933b855 Mon Sep 17 00:00:00 2001 From: lpm0073 Date: Mon, 13 Nov 2023 18:29:24 -0600 Subject: [PATCH 1/6] refactor: remove remaining set-output calls --- .github/workflows/versionBump.yml | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/.github/workflows/versionBump.yml b/.github/workflows/versionBump.yml index 3aca89f..a1f2202 100644 --- a/.github/workflows/versionBump.yml +++ b/.github/workflows/versionBump.yml @@ -43,20 +43,8 @@ env: GITHUB_TOKEN: ${{ secrets.PAT }} - - name: Check versions - id: check_versions - run: | - if [ "$CURRENT_VERSION" != "$NEXT_VERSION" ]; then - echo "::set-output name=version_changed::true" - else - echo "::set-output name=version_changed::false" - fi - env: - CURRENT_VERSION: ${{ env.CURRENT_VERSION }} - NEXT_VERSION: ${{ env.NEXT_VERSION }} - - name: Update __version__ - if: steps.check_versions.outputs.version_changed == 'true' + if: env.CURRENT_VERSION != env.NEXT_VERSION id: update_version run: | echo "__version__ = '${{ env.NEXT_VERSION }}'" > __version__.py From def807c31fd92c092b155f3c1d3b3f785cda5540 Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Tue, 14 Nov 2023 00:29:58 +0000 Subject: [PATCH 2/6] chore: [gh] Update __version__.py to [skip ci] --- __version__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/__version__.py b/__version__.py index 850505a..cf194e0 100644 --- a/__version__.py +++ b/__version__.py @@ -1 +1 @@ -__version__ = '0.1.10' +__version__ = '' From 528fa71dc0fc008bd7098686cab94198a961f5c3 Mon Sep 17 00:00:00 2001 From: lpm0073 Date: Mon, 13 Nov 2023 18:36:27 -0600 Subject: [PATCH 3/6] fix: CURRENT_VERSION was unassigned --- .github/workflows/versionBump.yml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/.github/workflows/versionBump.yml b/.github/workflows/versionBump.yml index a1f2202..9349a0c 100644 --- a/.github/workflows/versionBump.yml +++ b/.github/workflows/versionBump.yml @@ -43,8 +43,20 @@ env: GITHUB_TOKEN: ${{ secrets.PAT }} + - name: Check versions + id: check_versions + run: | + if [ "$CURRENT_VERSION" != "$NEXT_VERSION" ]; then + echo "VERSION_CHANGED=true" >> $GITHUB_ENV + else + echo "VERSION_CHANGED=false" >> $GITHUB_ENV + fi + env: + CURRENT_VERSION: ${{ env.CURRENT_VERSION }} + NEXT_VERSION: ${{ env.NEXT_VERSION }} + - name: Update __version__ - if: env.CURRENT_VERSION != env.NEXT_VERSION + if: env.VERSION_CHANGED == 'true' id: update_version run: | echo "__version__ = '${{ env.NEXT_VERSION }}'" > __version__.py @@ -55,5 +67,4 @@ git push https://${{ secrets.PAT }}@github.com/${{ github.repository }}.git HEAD:${{ github.ref }} env: GITHUB_TOKEN: ${{ secrets.PAT }} - CURRENT_VERSION: ${{ env.CURRENT_VERSION }} NEXT_VERSION: ${{ env.NEXT_VERSION }} From c66a098f1e4d999860d55fd26a7fc2ce8f2820e1 Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Tue, 14 Nov 2023 00:37:12 +0000 Subject: [PATCH 4/6] chore: [gh] Update __version__.py to 0.1.11 [skip ci] --- __version__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/__version__.py b/__version__.py index cf194e0..13b7089 100644 --- a/__version__.py +++ b/__version__.py @@ -1 +1 @@ -__version__ = '' +__version__ = '0.1.11' From 271a11e2e51d54c198e9966d288550d7181ed9a0 Mon Sep 17 00:00:00 2001 From: lpm0073 Date: Mon, 13 Nov 2023 18:43:55 -0600 Subject: [PATCH 5/6] add null steps --- .github/workflows/versionBump.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/versionBump.yml b/.github/workflows/versionBump.yml index 9349a0c..912bdba 100644 --- a/.github/workflows/versionBump.yml +++ b/.github/workflows/versionBump.yml @@ -43,6 +43,10 @@ env: GITHUB_TOKEN: ${{ secrets.PAT }} + - name: null step + id: null_step + run: echo "i do not do anything" + - name: Check versions id: check_versions run: | @@ -55,6 +59,11 @@ CURRENT_VERSION: ${{ env.CURRENT_VERSION }} NEXT_VERSION: ${{ env.NEXT_VERSION }} + - name: another null step + id: another_null_step + run: echo "i do not do anything either." + + - name: Update __version__ if: env.VERSION_CHANGED == 'true' id: update_version From fbac0d24bfd89c93851f5113627c56876fd86609 Mon Sep 17 00:00:00 2001 From: lpm0073 Date: Mon, 13 Nov 2023 18:48:31 -0600 Subject: [PATCH 6/6] docs: lint inline documentation --- .github/workflows/versionBump.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/versionBump.yml b/.github/workflows/versionBump.yml index 912bdba..54e9bfa 100644 --- a/.github/workflows/versionBump.yml +++ b/.github/workflows/versionBump.yml @@ -45,7 +45,7 @@ - name: null step id: null_step - run: echo "i do not do anything" + run: echo "i ensure that NEXT_VERSION is set." - name: Check versions id: check_versions @@ -61,7 +61,7 @@ - name: another null step id: another_null_step - run: echo "i do not do anything either." + run: echo "i ensure that CURRENT_VERSION, NEXT_VERSION and VERSION_CHANGED are set." - name: Update __version__ @@ -77,3 +77,4 @@ env: GITHUB_TOKEN: ${{ secrets.PAT }} NEXT_VERSION: ${{ env.NEXT_VERSION }} + VERSION_CHANGED: ${{ env.VERSION_CHANGED }}