Skip to content

Refactor PDCBuffer #26

@micahpw

Description

@micahpw

Decouple start/stop stream commands from port connections:

We should be able to listen on multiple ports and optionally notify the user when data or configuration frames are received. The start and stop stream commands aren't always necessary. Passive listening on a port will help debug if the upstream PDC is actually sending data. Allow for multiple port connections. Typically we should see 1-2 ports but might as well allow for many.

Decouple Connecting to the PDC from requesting a configuration frame.

In some cases the PDC will occasionally send the configuration frame. We should be able to just connect and passively listen for data.

The start stream api should be replaced with a start buffer or similar. We want to differentiate between sending a start_stream command vs accumulating data. If the PDC happens to close the connection after sending a command, which might happen in some configurations, we want to keep the PDCBuffer object alive instead of panic.

Enable Logging at various levels

Debug - Most detailed, for every configuration or data frame received. Warn users if proprietary formatted data is received.
Info - Relevant info like configuration frame received. Buffer accumulation started. Etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions