Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Add SkipTo plugin by PayPal Accessibility Team #196

Closed
wants to merge 5 commits into from

Conversation

mnigh
Copy link
Collaborator

@mnigh mnigh commented Jun 22, 2022

Resolves #92.

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gc-accessibility-passport ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 11:17AM (UTC)

@@ -36,6 +37,7 @@ function MyApp({ Component, pageProps }: AppProps): React.ReactElement {
}}
>
<Component {...pageProps} />
<Script src="https://paypal.github.io/skipto/downloads/js/skipto.min.js" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonikid15 Including this library from a third-party CDN is not a good idea for several reasons including reliability and security. There is an npm package available but it is not written in TypeScript and not written in module syntax for importing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including this library from a third-party CDN is not a good idea for several reasons including reliability and security. There is an npm package available but it is not written in TypeScript and not written in module syntax for importing.

Please see previous comments, and this issue that speaks to the potential changes afoot with the library and maintainers. Is implementing this library a requirement for this project?

@mnigh mnigh added the question Further information is requested label Jun 22, 2022
@mnigh mnigh changed the base branch from version-5.0.0 to version-5.0.1 June 23, 2022 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement skiptoNav
3 participants