-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New extension: SecretCode #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the extension is pretty cool that's for sure but I have a few questions and problems :
- Can you make the
StringToStringListObjectVar
function private (right click -> private). This means the function will only be usable internally for the extension has the goal of your extension isn't to split a string into a list of strings. - I think there is a need for more actions and conditions to be added. Namely
- There should be a way for the game creator to check if the code is being inputted or isn't being inputted to avoid triggering a "code false" event by accident or repeatedly
- There should be an action to start and stop recording the inputs (other than just disabling the behaviour)
- It should also be possible to enter a code with an action. An action like : "enter a new input in the code"
- Finally, it should be possible to set the code in the events as the code may be dynamic !
- As a bonus you should consider writing some documentation on it just to be sure
Overall this is a good concept but it needs some improvements.
Take your time and it will become a great extension👍
Sorry for the delay. I will address all these issues and upload it again. But I don't know if I understood some parts:
You mean, for example, every time the player entered one of the code keys correctly, trigger a condition? If so, what should be the condition? Currently, the handling of the code keys are done inside, and once entered in the correct order they trigger that the code was entered, but only once. It only triggers again if the user resets the status of the verification. Also, what you mean by
You mean, editing the code? Or just setting the flag that the code was entered correctly? For the documentation, sure. Where should I do this? |
Hey ! What I mean by
Is that : you should be able to check if the code is starting to be inputted with an string expression called : That's all I hope it's not too much take your time :) |
I decided to create 2 behaviors:
Question: how do I update the zips when already in the PR? |
@VegeTato how do I update the zips when already in the PR? |
Write !update then space, then upload your new version of the extension example: |
Can't update the extension, as it doesn't pass automatic tests:
|
✅ Successfully updated the extension. |
I added an icon to the extension, i believe that's a requirement. Sorry for the delay, merging this now! |
@arthuro555 how could I add the docs for my extension? |
Description
Allows to input a secret code for cheats and easter eggs.
How to use the extension
Put
SecretCode
behavior on any object, and checkcode entered correctly
condition if the code was entered correctly. There is also an action to reset code entered status.Checklist
What tier of review do you aim for your extension?
Community (Unreviewed)
Example file
Secret Code Example.zip
Extension file
SecretCode.zip