Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community] [WithThreeJs] version 0.9.0 #903

Merged
merged 9 commits into from
Sep 5, 2023

Conversation

PANDAKO-GitHub
Copy link
Contributor

Supports built-in 3D.
Supports multiple 3D cameras.

@PANDAKO-GitHub PANDAKO-GitHub requested a review from a team as a code owner June 5, 2023 03:51
@@ -904,9 +923,11 @@
{
"type": "BuiltinCommonInstructions::JsCode",
"inlineCode": [
"THREE.Cache.enabled = true;\r",
"THREE.Cache.enabled = true;// ローダーのためにキャッシュの有効化\r",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these characters cause a problem? (I know some people have problems publishing games with special characters, but that might only apply to file names?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there are similar characters in comments on the previous version, so this is probably not an issue.

@D8H
Copy link
Contributor

D8H commented Jun 8, 2023

Great to see an update!
We're planning a GDevelop release very soon, it could worth waiting for it to check nothing broke.

@D8H
Copy link
Contributor

D8H commented Jul 6, 2023

Does this version work well with the current version?
Do you have a small example I could use to check it before merging it?

@D8H D8H merged commit cd7f8f4 into GDevelopApp:main Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants