Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load replacer text files from the SHbundle itself #41

Closed
mn5hk opened this issue Feb 16, 2023 · 8 comments
Closed

load replacer text files from the SHbundle itself #41

mn5hk opened this issue Feb 16, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@mn5hk
Copy link
Collaborator

mn5hk commented Feb 16, 2023

Currently, we are loading replacer files as hardcoded paths to our drivespace. This should be rewritten with a relative file path such that the user can load the default values for the replaces when they install the pyshbundle module.

image

However, this runs into the risk that the replacer file is not updated, or that the user fails to update the replacer text file because of lack of awareness about its need. As such, additionally, the function should prompt the user to use custom replacer file as and when they find it necessary.

@mn5hk mn5hk added the enhancement New feature or request label Feb 16, 2023
@mn5hk mn5hk self-assigned this Feb 16, 2023
@mn5hk
Copy link
Collaborator Author

mn5hk commented Feb 16, 2023

image

@mn5hk
Copy link
Collaborator Author

mn5hk commented Feb 16, 2023

@mn5hk mn5hk pinned this issue Feb 16, 2023
@mn5hk
Copy link
Collaborator Author

mn5hk commented Feb 16, 2023

Create a new pyshbundle release v 0.0.1.10.

conda activate demo
python setup.py sdist
twine upload '/mnt/Data/pyshbundle/pyshbundle/dist/pyshbundle-0.0.1.10.tar.gz'

@mn5hk
Copy link
Collaborator Author

mn5hk commented Feb 16, 2023

Successful to load npy file in v 0.0.1.11;
image

Also include path_tn14 and path_tn13 into the package.

@mn5hk
Copy link
Collaborator Author

mn5hk commented Feb 17, 2023

The long means are only for the RL06 version and will need updating on every new version release of the product. The replacement files change every month with the monthly release of new data.

This needs to be incorporated in the documentation part #31

@mn5hk
Copy link
Collaborator Author

mn5hk commented Feb 17, 2023

Longterm means are being loaded in .npy format. This may need to be changed or better described in the descriptions.

#31
#26

@mn5hk
Copy link
Collaborator Author

mn5hk commented Feb 20, 2023

package data not included in v0.0.2.1

@mn5hk mn5hk closed this as completed Feb 20, 2023
@mn5hk mn5hk reopened this Feb 20, 2023
@mn5hk mn5hk unpinned this issue Apr 16, 2023
@lsmvivek
Copy link
Collaborator

We can simply use relative paths. As present in the examples notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants