From 0780a46a6c9f33d75210b7c73ac6fe5f41f1fa1f Mon Sep 17 00:00:00 2001
From: "Ed (ODSC)" <ed.lloyd-davies@opendataservices.coop>
Date: Wed, 6 Sep 2023 12:16:22 +0100
Subject: [PATCH] cove_rdls/templates/cove_rdls/additional_fields_table.html:
 Improve table

---
 .../cove_rdls/additional_fields_table.html    | 66 +++++++++++++++++--
 1 file changed, 59 insertions(+), 7 deletions(-)

diff --git a/cove_rdls/templates/cove_rdls/additional_fields_table.html b/cove_rdls/templates/cove_rdls/additional_fields_table.html
index 6c55f48..f2e8101 100644
--- a/cove_rdls/templates/cove_rdls/additional_fields_table.html
+++ b/cove_rdls/templates/cove_rdls/additional_fields_table.html
@@ -6,31 +6,83 @@
     <thead>
     <tr>
         <th class="">{% trans 'Field Name' %}</th>
+        <th class="">{% trans 'Field Path' %}</th>
         <th class="">{% trans 'Usage Count' %}
         <th class="">{% trans 'First 3 Values' %}</th>
-        <th class="">{% trans 'First 3 Locations' %}</th>
+        <th class="">{% trans 'Child Fields' %}</th>
     </tr>
     </thead>
     <tbody>
-    {% for key, value in additional_fields.items %}
+    {% for full_path, info in additional_fields.items %}
+        {% if info.root_additional_field %}
             <tr>
                 <td>
-                    {{ value.field_name }}
+                    {{ info.field_name }}
                 </td>
                 <td>
-                    {{ value.examples|length }}
+                    {{ full_path }}
                 </td>
                 <td>
-                    {% for error in value.examples|slice:":3" %}
+                    {{ info.count }}
+                </td>
+                <td>
+                    {% for example in info.examples|slice:":3" %}
                     <li>
-                        {{ error.path|join:"/" }}
+                        {{ example }}
                     </li>
                     {% endfor %}
                 </td>
                 <td>
-                    {{ value.path }}
+                    {% if info.additional_field_descendance %}
+                        {{info.additional_field_descendance|length}}
+                        <a data-toggle="modal" data-target="#additional-field-{{full_path|slugify}}">{% trans "(See child fields)" %}</a>
+                    {% endif %}
                 </td>
             </tr>
+         {% endif %}
     {% endfor %}
     </tbody>
 </table>
+
+{% for parent_full_path, parent_info in additional_fields.items %}
+  {% if parent_info.root_additional_field and parent_info.additional_field_descendance %}
+    <div class="modal fade" id="additional-field-{{parent_full_path|slugify}}" tabindex="-1" role="dialog">
+      <div class="modal-dialog modal-lg" role="document">
+        <div class="modal-content">
+          <div class="modal-header">
+            <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
+            <h4>{% blocktrans %}Child fields of {{parent_full_path}}{% endblocktrans %} </h4>
+
+          </div>
+          <div class="modal-body">
+            <table class="table">
+               <thead>
+                 <tr>
+                   <th> {% trans 'Field' %}</th>
+                   <th> {% trans 'Path to Field' %}</th>
+                   <th> {% trans 'Usage Count' %}</th>
+                   <th> {% trans 'Examples (first 3)' %}</th>
+                 </tr>
+               </thead>
+               <tbody>
+               {% for full_path, info in parent_info.additional_field_descendance.items %}
+                 <tr>
+                    <td>{{info.field_name}}</td>
+                    <td>{{info.path}}</td>
+                    <td>{{info.count}}</td>
+                    <td>
+                      {% for example in info.examples %}
+                        {{example}} <br />
+                      {% endfor %}
+                    </td>
+                 </tr>
+               {% endfor %}
+               </tbody>
+            </table>
+          </div>
+        </div>
+      </div>
+    </div>
+  {% endif %}
+{% endfor %}
+