Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify scanning workflows to support FAC ClamAV Image #1159

Closed
asteel-gsa opened this issue May 25, 2023 · 6 comments
Closed

Modify scanning workflows to support FAC ClamAV Image #1159

asteel-gsa opened this issue May 25, 2023 · 6 comments
Assignees
Labels
infrastructure For the invisible bits that make it all go.

Comments

@asteel-gsa
Copy link
Contributor

asteel-gsa commented May 25, 2023

When this PR is approved and merged @asteel-gsa will run the workflow and generate a new package with the name of clamav:YYYYMMDD and will be accessible via docker pull ghcr.io/GSA-TTS/FAC/clamav:20230525 (TBD after run)

The Trivy Scan, matrix and docker pull need to be modified to support this new package, pull the package from the GSA-TTS/FAC packages, and scan that image instead of using the docker hub clamav-rest:latest

Follow on from #1064

@asteel-gsa asteel-gsa added the infrastructure For the invisible bits that make it all go. label May 25, 2023
@asteel-gsa asteel-gsa changed the title Modify Scan Images Workflow to support FAC ClamAV Image Modify workflows to support FAC ClamAV Image May 25, 2023
@asteel-gsa asteel-gsa changed the title Modify workflows to support FAC ClamAV Image Modify scanning workflows to support FAC ClamAV Image May 25, 2023
@asteel-gsa
Copy link
Contributor Author

@JeanMarie-TTS TTS clamav: https://github.com/GSA-TTS/clamav-rest/pkgs/container/clamav-rest%2Fclamav

A new image will be built every sunday with YYYYMMDD
docker pull ghcr.io/gsa-tts/clamav-rest/clamav:20230530

@JeanMarie-PM
Copy link
Contributor

@asteel-gsa Can you provide more context? We already have clamav in GHCR - https://github.com/orgs/GSA-TTS/packages/container/package/fac%2Fclamav

@asteel-gsa
Copy link
Contributor Author

@asteel-gsa Can you provide more context? We already have clamav in GHCR - https://github.com/orgs/GSA-TTS/packages/container/package/fac%2Fclamav

Reference Ticket: Here
Upstream PR that was not merged into clamav-rest: PR
Comment to build our own image, that supports the freshclam proxy information: Here
Repo: TTS ClamAV
Replicating Freshclam entrypoint that would have been the original PR into upstream: Here
TTS ClamAV Packages: Here
Modified Entrypoint with freshclam proxy information: entrypoint.sh

@JeanMarie-PM
Copy link
Contributor

#1185 addresses using the image from ghcr/gsa-tts instead of the one from docker hub.

@mogul
Copy link
Contributor

mogul commented Jun 15, 2023

Can we close this one now?

@asteel-gsa
Copy link
Contributor Author

Can we close this one now?

I believe so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure For the invisible bits that make it all go.
Projects
None yet
Development

No branches or pull requests

3 participants