Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat validation variables as globals (source: 18F/fedramp-automation: 582) #278

Closed
14 tasks
danielnaab opened this issue Oct 25, 2022 · 1 comment
Closed
14 tasks

Comments

@danielnaab
Copy link
Member

Original issue: 18F#582

Extended Description
To prep for SchXslt usage, replace local variables usage with globals. Discovered by #529

Acceptance Criteria

  • Local variables with duplicate names removed.

Definition of Done

  • Acceptance criteria met
  • Unit test coverage of our code > 90% - needs automation story
  • Accessibility tests pass - needs automation story
  • Automated code quality checks pass
  • Security reviewed and reported - check in with Wes on what we could do here
  • Reviewed against plain language guidelines
  • Design QA passed
  • Code must be self-documenting
  • No local tech debt
  • Documentation updated
  • Architectural Decision Record completed as necessary for significant design choices
  • PR reviewed & approved
  • Source code merged
@danielnaab danielnaab changed the title Treat validation variables as globals - (source: 18F/fedramp-automation: 1294503699) Treat validation variables as globals - (source: 18F/fedramp-automation: 582) Oct 26, 2022
@danielnaab danielnaab changed the title Treat validation variables as globals - (source: 18F/fedramp-automation: 582) Treat validation variables as globals (source: 18F/fedramp-automation: 582) Oct 26, 2022
@danielnaab danielnaab moved this to 📋 Backlog in FedRAMP Automation Oct 26, 2022
@aj-stein-gsa
Copy link
Contributor

Re ADR 7, we will not use the previous constraint architecture as-is and the relevant code will soon be removed. I am closing this issue as not planned.

@aj-stein-gsa aj-stein-gsa closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in FedRAMP Automation Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants