diff --git a/features/fedramp_extensions.feature b/features/fedramp_extensions.feature index 423497d98..18daa7abd 100644 --- a/features/fedramp_extensions.feature +++ b/features/fedramp_extensions.feature @@ -113,6 +113,7 @@ Examples: | leveraged-authorization-has-valid-impact-level | | leveraged-authorization-nature-of-agreement | | marking | + | misplaced-response-components | | missing-response-components | | network-component-has-connection-security-prop | | network-component-has-implementation-point | @@ -337,6 +338,8 @@ Examples: | leveraged-authorization-nature-of-agreement-PASS.yaml | | marking-FAIL.yaml | | marking-PASS.yaml | + | misplaced-response-components-FAIL.yaml | + | misplaced-response-components-PASS.yaml | | missing-response-components-FAIL.yaml | | missing-response-components-PASS.yaml | | network-component-has-connection-security-prop-FAIL.yaml | diff --git a/src/validations/constraints/content/ssp-control-implementation-status-INVALID.xml b/src/validations/constraints/content/ssp-control-implementation-status-INVALID.xml index 01aea8746..1596cc8a5 100644 --- a/src/validations/constraints/content/ssp-control-implementation-status-INVALID.xml +++ b/src/validations/constraints/content/ssp-control-implementation-status-INVALID.xml @@ -5,9 +5,11 @@ uuid="12345678-1234-4321-8765-123456789012"> - - - + + + + + - + \ No newline at end of file diff --git a/src/validations/constraints/content/ssp-control-implementation-status-VALID.xml b/src/validations/constraints/content/ssp-control-implementation-status-VALID.xml index 715a29c66..0c774b0d5 100644 --- a/src/validations/constraints/content/ssp-control-implementation-status-VALID.xml +++ b/src/validations/constraints/content/ssp-control-implementation-status-VALID.xml @@ -358,6 +358,8 @@ + +

Some description of the authentication method.

@@ -445,31 +447,31 @@ + + +

Access Control Policy and Procedures (AC-1) is fully implemented in our system.

+
+ + + 11111111-0000-4000-9000-000000000001 + +
- - -

Access Control Policy and Procedures (AC-1) is fully implemented in our system.

-
- - - 11111111-0000-4000-9000-000000000001 - -
+ + +

Information System Component Inventory (CM-8) is partially implemented.

+
+ + + 11111111-0000-4000-9000-000000000001 + +
- - -

Information System Component Inventory (CM-8) is partially implemented.

-
- - - 11111111-0000-4000-9000-000000000001 - -
diff --git a/src/validations/constraints/content/ssp-misplaced-response-components-INVALID.xml b/src/validations/constraints/content/ssp-misplaced-response-components-INVALID.xml new file mode 100644 index 000000000..16ed10bf7 --- /dev/null +++ b/src/validations/constraints/content/ssp-misplaced-response-components-INVALID.xml @@ -0,0 +1,31 @@ + + + + + System To Be Authorized + +

This component reflects the system to be authorized.

+

A proper SSP should reference this correctly within a given statement to document implemented requirements per FedRAMP requirements.

+

This example SSP does not do that, it's invalid and has some problems.

+
+
+
+ + +

Implementation of controls for the System to be Authorized

+
+ + + + + +

This component reference would be valid if it was within the statement above, but it is not.

+

This constraint violation for the invalid file should warn users and developers repurposing valid syntax for NIST's upstream OSCAL generic use cases is not valid specifically for FedRAMP.

+
+
+
+
+
diff --git a/src/validations/constraints/content/ssp-missing-response-components-INVALID.xml b/src/validations/constraints/content/ssp-missing-response-components-INVALID.xml index 9af07aea0..64e940884 100644 --- a/src/validations/constraints/content/ssp-missing-response-components-INVALID.xml +++ b/src/validations/constraints/content/ssp-missing-response-components-INVALID.xml @@ -11,12 +11,14 @@ + + diff --git a/src/validations/constraints/fedramp-external-allowed-values.xml b/src/validations/constraints/fedramp-external-allowed-values.xml index c92f705ec..9acf13713 100644 --- a/src/validations/constraints/fedramp-external-allowed-values.xml +++ b/src/validations/constraints/fedramp-external-allowed-values.xml @@ -107,7 +107,7 @@ A physical or virtual network. - + Control Implementation Status The implementation status of the control. Implemented diff --git a/src/validations/constraints/fedramp-external-constraints.xml b/src/validations/constraints/fedramp-external-constraints.xml index af7ae5b20..3c756f19d 100644 --- a/src/validations/constraints/fedramp-external-constraints.xml +++ b/src/validations/constraints/fedramp-external-constraints.xml @@ -166,10 +166,20 @@ - - Missing Response Components + + By-Component Reference for Implemented Requirements Misplaced - Each implemented requirement MUST have at least one by-component reference to the source component implementing it. + A FedRAMP SSP MUST identify how the system implements each control requirement implemented at the per-statement level, not in other locations allowed for non-FedRAMP use cases. + +

NIST maintains OSCAL models that allow implemented requirements for controls to have references to the implementing components in multiple locations to support multiple use cases.

+

Despite the flexibility of NIST's upstream OSCAL models, FedRAMP only accepts OSCAL-based SSPs with the reference in one of those locations, see missing-response-components for more details about this requirement.

+

A constraint violation with this warning indicates a given SSP uses one of the valid locations for all NIST use cases, but not the only FedRAMP required location.

+
+
+ + By-Component Reference for Implemented Requirements Missing + + A FedRAMP SSP MUST identify how the system implements each control requirement implemented at the per-statement level and reference any component used to implement it.
diff --git a/src/validations/constraints/unit-tests/misplaced-response-components-FAIL.yaml b/src/validations/constraints/unit-tests/misplaced-response-components-FAIL.yaml new file mode 100644 index 000000000..ec7ca1a48 --- /dev/null +++ b/src/validations/constraints/unit-tests/misplaced-response-components-FAIL.yaml @@ -0,0 +1,9 @@ +test-case: + name: Negative Test for misplaced-response-components + description: >- + This test case validates the behavior of constraint + misplaced-response-components + content: ../content/ssp-misplaced-response-components-INVALID.xml + expectations: + - constraint-id: misplaced-response-components + result: fail diff --git a/src/validations/constraints/unit-tests/misplaced-response-components-PASS.yaml b/src/validations/constraints/unit-tests/misplaced-response-components-PASS.yaml new file mode 100644 index 000000000..42fc2c834 --- /dev/null +++ b/src/validations/constraints/unit-tests/misplaced-response-components-PASS.yaml @@ -0,0 +1,9 @@ +test-case: + name: Positive Test for misplaced-response-components + description: >- + This test case validates the behavior of constraint + misplaced-response-components + content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml + expectations: + - constraint-id: misplaced-response-components + result: pass