-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the extension doesn't remove DBus file and others. #1269
Comments
If the extension is uninstalled, the DBus file and others remain in the system. This can cause problems to other programs that interact with GSConnect. This patch fixes this issue by removing all the files when the extension is disabled, and recreating them when it is enabled. Fix GSConnect#1269
We discovered this doing some tests with an MR for integrating GSConnect with Desktop Icons NG. https://gitlab.com/rastersoft/desktop-icons-ng/-/merge_requests/216 |
I'm not really an active maintainer here, so I won't reject or approve this. My personal thoughts are:
Two options:
|
The big problem is when the extension is uninstalled, because it leaves "dirt" behind. Those files should be deleted. Is there an "uninstall" method for the extensions, called after being disabled and before being removed? If not, it would be a good idea, I think. I think that i could send a patch for that, in fact. |
BTW... what is that "unlock-dialog session mode"? I'm searching in google but can't find info... |
Oh, I think that I found something https://gjs.guide/extensions/overview/anatomy.html#metadata-json-required |
Ok, I added the "unlock-dialog" mode. |
There is no counterpart to the It's possible this could be done by the service itself, since it already watches for the service to be uninstalled, but again some real-world testing would be required to see that this didn't break anything else. GSConnect is already stitched together by a system of duct-tape, bubblegum and twine pulleys so I'm not keen on making that more fragile 🙂
Unfortunately the |
Describe the bug
After uninstalling the extension, the DBus file at ~/.local/share/dbus-1/services remain, and thus the service remains announced in DBus even when there is no code for serving it.
Steps To Reproduce:
Expected behavior
No service should be shown. But, instead, the gsconnect service is still announced as "activatable". Of course, any attempt to access it returns an error.
The text was updated successfully, but these errors were encountered: