Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

better embedding of mass and potential #24

Open
3 tasks done
nstarman opened this issue Jan 19, 2021 · 0 comments
Open
3 tasks done

better embedding of mass and potential #24

nstarman opened this issue Jan 19, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nstarman
Copy link
Collaborator

Description

Currently the mass and potential are embedded in a SkyCoord. This does not work very well as any operation that returns a new instance, like reshape means that the attributes need to be reassigned (separately reshaped).

Possible fixes:

  • Subclass SkyCoord, with hooks to properly maintain these attributes
  • embed in a table (SkyCoord is a valid mixin) ... but can tables be stacked depth-wise?
  • Xarray? but how does that deal with SkyCoords?

Checklist

  • Check out our contributing guidelines.
  • Check out our code of conduct.
  • Search the GitHub repository to see if a similar issue has already been posted. If a similar issue is closed, have a quick look to see if you are satisfied by the resolution. If not please go ahead and open an issue!
@nstarman nstarman added the enhancement New feature or request label Jan 19, 2021
@nstarman nstarman added this to the v0.2 milestone Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants