Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol docs w.r.t. call #113

Open
pnwamk opened this issue Oct 29, 2020 · 4 comments
Open

Update protocol docs w.r.t. call #113

pnwamk opened this issue Oct 29, 2020 · 4 comments

Comments

@pnwamk
Copy link
Contributor

pnwamk commented Oct 29, 2020

Since GaloisInc/cryptol#944 call is now more flexible (any expression can appear in operator position), we need to document this in the protocol.

@pnwamk
Copy link
Contributor Author

pnwamk commented Oct 29, 2020

(Also, mark call as deprecated in favor of just using evaluate_expression, since the latter is purely more expressive/useful than the former).

@weaversa
Copy link

call should be deprecated?

@pnwamk
Copy link
Contributor Author

pnwamk commented Oct 29, 2020

After chatting more with @david-christiansen it seems the suggestion to deprecate call was more of a comment on the JSON-RPC API and backend that I misinterpreted (sorry for any confusion). If the call method on the CryptolConnection Python class is useful we can absolutely keep it (and internally it will just be a thin wrapper around the more generic expression evaluation feature).

@weaversa
Copy link

weaversa commented Oct 29, 2020

evaluate_expression is certainly more expressive, but also more prone to error. One nice thing about call is that it takes JSON arguments, so passing a result from a previous invocation of a Cryptol function is trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants