Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a range of supported versions instead of just 1.X #38

Open
misode opened this issue Jan 9, 2024 · 1 comment
Open

Show a range of supported versions instead of just 1.X #38

misode opened this issue Jan 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@misode
Copy link
Member

misode commented Jan 9, 2024

No description provided.

@misode misode added the enhancement New feature or request label Jan 9, 2024
@Bloo-dev
Copy link
Member

Currently output.py specifies supported Minecraft versions for pushing releases to Modrinth and Smithed. These Minecraft Versions are fixed per major release version and do currently not reflect the actual minor versions supported by our data packs.

This is a major issue, not only for the website (which will only show supported major Minecraft versions), but also for Modrinth and Smithed, where data packs will be released and listed by minor versions, however, these do not reflect the intended version coverage by the data pack developer.

The following solution has been proposed in a related conversation on discord (private channel, hence no link):

[Bloo:] In output.py we'll continue to specify supported versions as a fallback, however, each module can also specify its own supported versions in its beet.yaml which must be subset of the supported versions in output.py. If a module does not specify its own set, the set from output.py is used.

We should use data pack versions for all version specifications mentioned above and only translate those to minecraft versions when the modules are published to vendors (gm4.co, Morinth, Smithed).

Furthermore, some of our data packs currently specify a set of data pack versions with their overlays. These data pack versions must be subset of the supported versions listed in the packs beet.yaml:

[Misode:] [...] all the overlay ranges need to fit in the supported versions field (which could be validated by a plugin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants