Errors while generating

[chuckwagoncomputing]

Recently we started getting errors. This happens with both Kicad 6 and Kicad 7.
We're using @leoheck's branch.

Traceback (most recent call last):
  File "/home/david/Downloads/rusefi/KiCad-Diff/bin/../kidiff/kidiff.py", line 934, in <module>
    commit1, commit2, commit_datetimes = scm.get_boards(kicad_pcb_path, repo_path, kicad_project_dir, board_filename, commit1, commit2)
TypeError: cannot unpack non-iterable NoneType object

Most recent run without errors was 2/12/23: https://github.com/rusefi/rusefi/actions/runs/4158982349
First run with errors was 2/25/23: https://github.com/rusefi/rusefi/actions/runs/4270675246

[leoheck]

Ah, try to use the version of the master of this repo this time. I think my version has diverged a bit, but the master on Gasman2014KiCad-Diff may have the latest fixes.

[leoheck]

My branch may have issues since I am looking for the best way it will be for Kicad 7.

[chuckwagoncomputing]

I checked just now and this repo has the same behavior.

[chuckwagoncomputing]

Also, in my checking, I tried older versions of your repo, and it still behaved the same with 3205daa, which was before the last error-free run, so something else must have changed, not your code.
I've done a bit of digging, but haven't found the culprit yet.
The two jobs were on different Github runner images.
Working run image info
Broken run image info

The only thing I've tried the older version of so far is Git, but that didn't fix it. (Though I tried that on my laptop, which is running Arch rather than Ubuntu)

[chuckwagoncomputing]

Also, it only gives the error when there weren't any changes between the two commits. If there were changes, a diff is produced without error.

[chuckwagoncomputing]

Possibly because get_boards returns nothing in

KiCad-Diff/kidiff/scms/git.py

Line 47 in b3052ae

return

Though that line was added Jan. 30, so I don't understand how the Feb. 12 run didn't give any errors.