From d48aefb0d9b0e7fddc4380d49235d38edf26eecc Mon Sep 17 00:00:00 2001 From: Saejin Mahlau-Heinert <saejinmh@gmail.com> Date: Fri, 11 Sep 2020 12:51:27 -0400 Subject: [PATCH 1/3] Fix issue with Docker action Push job depended on old `test` job instead of renamed `test-compile`. --- .github/workflows/docker-publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml index c309190..0a1a190 100644 --- a/.github/workflows/docker-publish.yml +++ b/.github/workflows/docker-publish.yml @@ -39,7 +39,7 @@ jobs: # See also https://docs.docker.com/docker-hub/builds/ push: # Ensure test job passes before pushing image. - needs: test + needs: test-compile runs-on: ubuntu-latest if: github.event_name == 'push' From 07f88b443835f6f9c889469b07501adcc207c15a Mon Sep 17 00:00:00 2001 From: Saejin Mahlau-Heinert <saejinmh@gmail.com> Date: Fri, 11 Sep 2020 12:55:28 -0400 Subject: [PATCH 2/3] Remove release note printing A lot of issue cropped up with characters not being escaped correctly, especially '`', which caused shell weirdness. --- .github/workflows/validate-pr.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index ecbb397..0f9ddb0 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -33,4 +33,3 @@ jobs: run: | echo Old Version: ${{ steps.validate-pr-metadata.outputs.old-version }} echo New Version: ${{ steps.validate-pr-metadata.outputs.version }} - echo Release Notes: ${{ steps.validate-pr-metadata.outputs.release-notes }} From 22a62832e707857196defbd9380b0eaf8fe47887 Mon Sep 17 00:00:00 2001 From: Saejin Mahlau-Heinert <saejinmh@gmail.com> Date: Fri, 11 Sep 2020 12:56:14 -0400 Subject: [PATCH 3/3] Remove printing release notes on an actual release This had the same issues as validate-pr. --- .github/workflows/release.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e2bf7b3..308794d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -27,7 +27,6 @@ jobs: run: | echo Old Version: ${{ steps.bump-tag-version.outputs.old-version }} echo New Version: ${{ steps.bump-tag-version.outputs.version }} - echo Release Notes: ${{ steps.bump-tag-version.outputs.release-notes }} - name: Create Release if: steps.bump-tag-version.outputs.version != '' uses: actions/create-release@v1