Skip to content

[BE+FE] refactor todo for handoff #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
in-mai-space opened this issue Mar 16, 2025 · 0 comments · Fixed by #182
Closed
5 tasks done

[BE+FE] refactor todo for handoff #173

in-mai-space opened this issue Mar 16, 2025 · 0 comments · Fixed by #182
Assignees
Labels
handoff Changes made for handoff refactor Reorganize, clean, simplify codebase

Comments

@in-mai-space
Copy link
Contributor

in-mai-space commented Mar 16, 2025

Things to refactor before handoff

  • abstract out method isManager
  • consider consolidating types and validators into one file for the sake of maintaining code organization
  • change type naming convention to PascalCase instead of ALL_CAPS since the latter generally implies constant
  • code could (optionally) be reorganized (a lot of files in backend/src could be put inside config)
  • certain methods and classes could be better named (instead of NudgeServiceImpl call it NudgeService, and call the interface NudgeServiceProps)
@in-mai-space in-mai-space added the refactor Reorganize, clean, simplify codebase label Mar 16, 2025
@in-mai-space in-mai-space changed the title [BE+FE] refactor notes for handoff [BE+FE] refactor todo for handoff Mar 16, 2025
@in-mai-space in-mai-space linked a pull request Mar 24, 2025 that will close this issue
5 tasks
@in-mai-space in-mai-space added the handoff Changes made for handoff label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
handoff Changes made for handoff refactor Reorganize, clean, simplify codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants