Skip to content

Commit ecac2d9

Browse files
Merge pull request #2 from GeoNode/django_upgrade
Django upgrade to 4.2
2 parents ed69e5a + 594594a commit ecac2d9

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

dynamic_rest/filters.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from functools import reduce
88
from rest_framework import serializers
99
from rest_framework.exceptions import ValidationError
10-
from rest_framework.fields import BooleanField, NullBooleanField
10+
from rest_framework.fields import BooleanField
1111
from rest_framework.filters import BaseFilterBackend, OrderingFilter
1212

1313
from dynamic_rest.utils import is_truthy
@@ -148,7 +148,7 @@ def rewrite_filters(fs, serializer):
148148
out = {}
149149
for node in fs.values():
150150
filter_key, field = node.generate_query_key(serializer)
151-
if isinstance(field, (BooleanField, NullBooleanField)):
151+
if isinstance(field, BooleanField):
152152
node.value = is_truthy(node.value)
153153
out[filter_key] = node.value
154154

install_requires.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
Django>=2.2,<4.2
2-
djangorestframework>=3.11.2,<3.15
1+
Django>=2.2,<4.3
2+
djangorestframework>=3.14.0,<3.15
33
inflection>=0.4.0
44
requests
55
hashids>=1.3.1

requirements.benchmark.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
dj-database-url==0.3.0
22
django-debug-toolbar==1.7
3-
Django>=2.2,<4.2
4-
djangorestframework>=3.11.2,<3.15
3+
Django>=2.2,<4.3
4+
djangorestframework>=3.14.0,<3.15
55
djay>=0.0.9
66
flake8>=3.0
77
psycopg2-binary==2.9.3

tox.ini

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ addopts=--tb=short
44
[tox]
55
envlist =
66
py310-lint,
7-
{py37,py38,py39,py310}-django{22,31,32,40,41}-drf{311,312,313,314},
7+
{py37,py38,py39,py310}-django{22,31,32,40,41,42}-drf{311,312,313,314},
88

99
[testenv]
1010
commands = ./runtests.py --fast {posargs} --coverage -rw
@@ -16,6 +16,7 @@ deps =
1616
django32: Django>=3.2,<3.3
1717
django40: Django>=4.0,<4.1
1818
django41: Django>=4.1,<4.2
19+
django42: Django>=4.2,<4.3
1920
drf311: djangorestframework>=3.11.2,<3.12
2021
drf312: djangorestframework>=3.12,<3.13
2122
drf313: djangorestframework>=3.13,<3.14
@@ -29,6 +30,6 @@ deps = -rrequirements.txt
2930
[testenv:py310-drf314-benchmarks]
3031
commands = ./runtests.py --benchmarks
3132
deps =
32-
Django==4.1.1
33+
Django>=4.2,<4.3
3334
djangorestframework==3.14
3435
-rrequirements.benchmark.txt

0 commit comments

Comments
 (0)