Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #12594] Error when saving a new map #12595

Merged
merged 8 commits into from
Sep 26, 2024
Merged

[Fixes #12594] Error when saving a new map #12595

merged 8 commits into from
Sep 26, 2024

Conversation

mattiagiupponi
Copy link
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi self-assigned this Sep 20, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Sep 20, 2024
@mattiagiupponi mattiagiupponi linked an issue Sep 20, 2024 that may be closed by this pull request
Error when saving a new map #12594
Closed
@etj etj changed the title [Fixes #12594] Error when saing a new map [Fixes #12594] Error when saving a new map Sep 20, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.26%. Comparing base (5bcbd82) to head (c1e69b2).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #12595   +/-   ##
=======================================
  Coverage   64.26%   64.26%           
=======================================
  Files         888      888           
  Lines       53619    53627    +8     
  Branches     6608     6614    +6     
=======================================
+ Hits        34458    34464    +6     
- Misses      17646    17647    +1     
- Partials     1515     1516    +1

giohappy
giohappy requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattiagiupponi

  • I think SETTINGS_MAPPING is not a concern of the API module.
  • this mapping can be used in other places outside the API

For the reasons above I would implement the "mapping" inside the User model with something like:

def can_change_resource_field(self, resource, field):
        match field:
            case "is_published":
                return self.can_publish(resource)

@giohappy giohappy merged commit 30b84a2 into master Sep 26, 2024
16 checks passed
@giohappy giohappy deleted the ISSUE_12594 branch September 26, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giohappy giohappy giohappy approved these changes

Assignees

@mattiagiupponi mattiagiupponi

Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when saving a new map
2 participants
@mattiagiupponi @giohappy