New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate using Smartline as alternative to initial coastal mask #20

Open

robbibt opened this issue Jul 30, 2020 · 0 comments

Assignees

Labels

Member

robbibt commented Jul 30, 2020 •

edited

Loading

Pros:

Much simpler code
More flexibility to modify MNDWI threshold

Cons:

Would need to be modified in some areas of extreme change

E.g. update contour_preprocess with rasterisation of smartline buffer:

    buffered_geom = smartline_gdf.simplify(30).buffer(2000)
    coastal_buffer = rasterize(shapes=buffered_geom,
                               out_shape=yearly_ds.geobox.shape,
                               transform=yearly_ds.geobox.transform,
                               all_touched=True).astype(bool)
    buffer_ocean = ~coastal_buffer
    buffer_land = ~coastal_buffer

The text was updated successfully, but these errors were encountered:

robbibt added the enhancement label

robbibt self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment