Merge pull request #331 from JamesParrott/pyshp-3.0.0-alpha-pylint-suppress-TODO

Pyshp 3.0.0 alpha pylint suppress todo

Author: JamesParrott

.github/workflows/run_checks_build_and_test.yml

@@ -27,9 +27,8 @@ jobs:
         pip install pytest pylint pylint-per-file-ignores
         pip install -e .
     - name: run Pylint for errors and warnings only
-      continue-on-error: true
       run: |
-        pylint --disable=R,C test_shapefile.py src/shapefile.py
+        pylint --disable=C test_shapefile.py src/shapefile.py
 
   build_wheel_and_sdist:
     runs-on: ubuntu-latest

pyproject.toml

@@ -112,17 +112,27 @@ load-plugins=[
     "pylint_per_file_ignores",
 ]
 
-[tool.pylint.'MESSAGES CONTROL']
 # Silence warning: shapefile.py:2076:20: W0212: Access to a protected
 #                  member _from_geojson of a client class (protected-access)
-#
+# Silence remarks:
+# src\shapefile.py:338:0: R0914: Too many local variables (21/15) (too-many-locals)
+# src\shapefile.py:338:0: R0912: Too many branches (24/12) (too-many-branches)
+# src\shapefile.py:338:0: R0915: Too many statements (52/50) (too-many-statements)
+# src\shapefile.py:470:0: R0902: Too many instance attributes (9/7) (too-many-instance-attributes)
+# src\shapefile.py:471:4: R0913: Too many arguments (6/5) (too-many-arguments)
+# src\shapefile.py:471:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
+# src\shapefile.py:506:4: R0911: Too many return statements (10/6) (too-many-return-statements)
+# src\shapefile.py:878:0: R0903: Too few public methods (0/2) (too-few-public-methods)
+# src\shapefile.py:1981:0: R0904: Too many public methods (23/20) (too-many-public-methods)
+# src\shapefile.py:2117:17: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
 # Silence warnings: test_shapefile.py:{783,786,799,803,06,1195}:19:
 #                   W0212: Access to a protected member _offsets of a
 #                   client class (protected-access)
 #
 # Toml multi-line string used instead of array due to:
 # https://github.com/christopherpickering/pylint-per-file-ignores/issues/160
-per-file-ignores = """
-    shapefile.py:W0212
-    test_shapefile.py:W0212
-"""
+[tool.pylint.'messages control']
+per-file-ignores = [
+    "/src/shapefile.py:W0212,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0917,R1732",
+    "test_shapefile.py:W0212,R1732",
+]