Allow pylint step to fail CI. Suppress undefined-loop-variable

Author: JamesParrott

.github/workflows/run_checks_build_and_test.yml

@@ -27,7 +27,6 @@ jobs:
         pip install pytest pylint pylint-per-file-ignores
         pip install -e .
     - name: run Pylint for errors and warnings only
-      continue-on-error: true
       run: |
         pylint --disable=C test_shapefile.py src/shapefile.py
 

src/shapefile.py

@@ -558,7 +558,7 @@ def __geo_interface__(self) -> GeoJsonShapeT:
                 ps = part
 
             # coordinates.append([tuple(p) for p in self.points[part:]])
-            coordinates.append(list(self.points[part:]))
+            coordinates.append(list(self.points[part:]))  # pylint: disable=undefined-loop-variable (assert len(self.parts) >1)
 
             return {"type": "MultiLineString", "coordinates": coordinates}