Skip to content

Commit 270f103

Browse files
committed
chore: update tests
1 parent b7d01bc commit 270f103

File tree

4 files changed

+40
-1
lines changed

4 files changed

+40
-1
lines changed

src/main/java/io/getstream/client/AggregatedFeed.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public CompletableFuture<? extends List<? extends Group<Activity>>> getActivitie
8888
DefaultOptions.DEFAULT_LIMIT, DefaultOptions.DEFAULT_OFFSET, filter, marker);
8989
}
9090

91+
9192
public CompletableFuture<? extends List<? extends Group<Activity>>> getActivities(
9293
Offset offset, ActivityMarker marker) throws StreamException {
9394
return getActivities(
@@ -118,6 +119,7 @@ CompletableFuture<? extends List<? extends Group<Activity>>> getActivities(
118119
});
119120
}
120121

122+
121123
public <T> CompletableFuture<? extends List<? extends Group<T>>> getCustomActivities(
122124
Class<T> type) throws StreamException {
123125
return getCustomActivities(

src/main/java/io/getstream/cloud/CloudFlatFeed.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ public CompletableFuture<List<Activity>> getActivities(Limit limit, Offset offse
8989
return getActivities(limit, offset, DefaultOptions.DEFAULT_FILTER, ranking);
9090
}
9191

92+
93+
9294
CompletableFuture<List<Activity>> getActivities(
9395
Limit limit, Offset offset, Filter filter, String ranking) throws StreamException {
9496
final RequestOption[] options =
@@ -205,6 +207,7 @@ limit, offset, filter, DefaultOptions.DEFAULT_MARKER, new Ranking(ranking)
205207
});
206208
}
207209

210+
208211
public CompletableFuture<List<EnrichedActivity>> getEnrichedActivities() throws StreamException {
209212
return getEnrichedActivities(
210213
DefaultOptions.DEFAULT_LIMIT,

src/main/java/io/getstream/core/options/Filter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,4 +73,4 @@ public void apply(Request.Builder builder) {
7373
builder.addQueryParameter(op.type, op.value);
7474
}
7575
}
76-
}
76+
}

src/test/java/io/getstream/client/FlatFeedTest.java

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
import io.getstream.core.models.EnrichedActivity;
1010
import io.getstream.core.options.DiscardActors;
1111
import io.getstream.core.options.EnrichmentFlags;
12+
import io.getstream.core.options.Filter;
13+
import io.getstream.core.options.Limit;
14+
import io.getstream.core.options.Offset;
1215
import java.util.Collections;
1316
import java.util.List;
1417
import java8.util.concurrent.CompletionException;
@@ -127,4 +130,35 @@ public void testDiscardActorsOptions() {
127130
assert discardActors3 != null;
128131
assert discardActors4 != null;
129132
}
133+
134+
@Test
135+
public void testGetActivitiesWithRequestOptions() throws Exception {
136+
Client client =
137+
Client.builder(apiKey, secret)
138+
.httpClient(new OKHTTPClientAdapter(new OkHttpClient()))
139+
.build();
140+
141+
FlatFeed feed = client.flatFeed("flat", "test-request-options");
142+
143+
// Test with just DiscardActors
144+
DiscardActors discardActors = new DiscardActors("actor1", "actor2", "actor3");
145+
List<Activity> result1 = feed.getActivities(discardActors).join();
146+
assert result1 != null;
147+
148+
// Test with DiscardActors + Limit + Filter
149+
List<String> actors = java.util.Arrays.asList("actor4", "actor5");
150+
DiscardActors discardActors2 = new DiscardActors(actors);
151+
Filter filter = new Filter().refresh();
152+
List<Activity> result2 = feed.getActivities(new Limit(10), filter, discardActors2).join();
153+
assert result2 != null;
154+
155+
// Test with all parameters
156+
List<Activity> result3 = feed.getActivities(
157+
new Limit(20),
158+
new Offset(5),
159+
new Filter().refresh(),
160+
new DiscardActors("actor6", "actor7")
161+
).join();
162+
assert result3 != null;
163+
}
130164
}

0 commit comments

Comments
 (0)