Skip to content
This repository was archived by the owner on Dec 5, 2021. It is now read-only.

[Feature] Allow adding / tweaking hologram display lines on the display items hologram. #806

Open
mibby opened this issue Jan 31, 2021 · 6 comments
Labels
WontFix This will not be worked on

Comments

@mibby
Copy link

mibby commented Jan 31, 2021

Describe the Feature
Would it be possible to allow players to individually add hologram text to their shop display item hologram? Or at least allow customizing the hologram format globally for all shops?

Screenshots
The ShopChest plugin supports this with allowing holograms to be edited and tweaked.
link

Additional context
This can tie into #805 with allowing the hologram text to only appear when you hover over the shop.

@Ghost-chu
Copy link
Owner

We use nametag to show name not ArmorStand so it is impossible.

@Ghost-chu Ghost-chu added the WontFix This will not be worked on label Jan 31, 2021
@mibby
Copy link
Author

mibby commented Jan 31, 2021

Could you perhaps add a plugin hook for Holographic Displays then?

@Ghost-chu
Copy link
Owner

I'm afarid it may effect performance btw i will think about it.

1 similar comment
@Ghost-chu
Copy link
Owner

I'm afarid it may effect performance btw i will think about it.

@mibby
Copy link
Author

mibby commented Jan 31, 2021

Let me know if you need anyone to test it. ShopChest doesn't actually use Holographic Displays, but instead their own native implementation for comparison. https://github.com/EpicEricEE/ShopChest/blob/967b9f2ce37601ab7f9424048547c192d4771b7f/src/main/java/de/epiceric/shopchest/shop/Shop.java

I'd be fine settling for requiring HD as a dependency if it's easier to implement since I have other plugins that also rely on it.

@Andre601
Copy link
Contributor

I'm afarid it may effect performance btw i will think about it.

You could make an add-on, so that if people want it, they can use that and you don't suffer performance in QS for this feature.
But I personally doubt that this would have any big performance impact on QS itself and at most would effect HD.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
WontFix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants