make SVG interactivity work with Atom

[bjarthur]

anyone understand how the Juno interface works?

[Mattriks]

http://docs.junolab.org/latest/devdocs/communication.html ?

[bjarthur]

@pfitzseb has a nice fix

[bjarthur]

specifically, in src/Gadfly.js replace:

@render Juno.PlotPane p::Plot begin
    x, y = Juno.plotsize()
    set_default_plot_size(x*Gadfly.px, y*Gadfly.px)
    HTML(stringmime("text/html", p))
end

with:

function Juno.render(pp::Juno.PlotPane, p::Plot)
    x, y = Juno.plotsize()
    set_default_plot_size(x*Gadfly.px, (y-1)*Gadfly.px)
    w = Juno.Atom.blinkplot()
    Juno.Atom.Blink.body!(w, HTML(stringmime("text/html", p)))
end

[JianghuiDu]

My Gadfly.js doesn't have @render at all. Using Julia 1.1.0. Is there a fix?

[bjarthur]

sadly Gadfly still doesn't work with Juno. see #1256 for a possible solution.

[pfitzseb]

Should work once JunoLab/Atom.jl#243 is merged. I was sure I'd tried that before and it didn't make a difference, but it does. Sorry for the false alarm in #1256.

[bjarthur]

i can plot successfully, but the built-into-Gadfly interactivity still does not work. specifically, while hovering in the plot plane one should be able to press "?" and get a help panel explaining that one can pan and zoom with various keys.

atom 1.43.0, julia 1.3, dev Gadfly

is there something that we need to add to Gadfly to make this work?

[bjarthur]

doh, it works as is with dev Atom. thanks!