Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up larger source code files #1155

Open
tlnagy opened this issue May 27, 2018 · 3 comments
Open

Break up larger source code files #1155

tlnagy opened this issue May 27, 2018 · 3 comments

Comments

@tlnagy
Copy link
Member

tlnagy commented May 27, 2018

Several of the files are getting unwieldy in size, especially statistics.jl, guide.jl, and Gadfly.jl. I think it would make sense to break these up like what was done for Geoms. Thoughts?

 $ find . -name '*.jl' -type f | xargs wc -l

     415 ./aesthetics.jl
     277 ./bincount.jl
      81 ./color_misc.jl
     277 ./coord.jl
      83 ./data.jl
    1238 ./Gadfly.jl
     284 ./geom/bar.jl
     142 ./geom/beeswarm.jl
     138 ./geom/boxplot.jl
     129 ./geom/errorbar.jl
      41 ./geom/hexbin.jl
     166 ./geom/hvabline.jl
     293 ./geom/label.jl
     195 ./geom/line.jl
      56 ./geom/point.jl
     100 ./geom/polygon.jl
      96 ./geom/rectbin.jl
      72 ./geom/ribbon.jl
      90 ./geom/segment.jl
     379 ./geom/subplot.jl
      40 ./geom/violin.jl
      70 ./geometry.jl
    1193 ./guide.jl
     325 ./mapping.jl
     418 ./misc.jl
      12 ./open_file.jl
     199 ./poetry.jl
     674 ./scale.jl
     219 ./shapes.jl
    1892 ./statistics.jl
     378 ./theme.jl
     327 ./ticks.jl
      60 ./varset.jl
   10359 total
@Mattriks
Copy link
Member

I've started doing this for Guides in #1156

@tlnagy
Copy link
Member Author

tlnagy commented May 29, 2018

Awesome. It looks like guide.jl and statistics.jl are the worst offenders.

@bjarthur
Copy link
Member

i'd hold off on partitioning guide.jl and statistics.jl until #1116 is merged as fixing the conflicts would be more difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants