Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellar | Remove QF from production #4732

Closed
3 tasks done
maryjaf opened this issue Sep 15, 2024 · 11 comments
Closed
3 tasks done

Stellar | Remove QF from production #4732

maryjaf opened this issue Sep 15, 2024 · 11 comments
Assignees
Labels
bug Something isn't working Stellar

Comments

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 15, 2024

Describe the bug

Stellar donation doesn't work for QF, buy users are not warn completely to understand it's not eligible.

  • Remove the QF banner shown in the stellar donation page, BOTH in connected and not connected scenarios

image

  • Remove the matching amount in project card in AMOUNT screen like above.
    image

  • Add a toast message like this (with the same styling) and change the copy:
    image

Make your donation eligible for matching
Donations made on {eligible QF round chains} are eligible to be matched. Stellar is not eligible for this round.
Go back and make sure you're on the right network. {linked to https://giveth.io/donate/hand-protocol }

@maryjaf maryjaf added the bug Something isn't working label Sep 15, 2024
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Sep 15, 2024
@MoeNick MoeNick changed the title The QF banner should be removed from stellar donation page Stellar | Remove QF from production Sep 15, 2024
@MoeNick
Copy link
Member

MoeNick commented Sep 15, 2024

@Meriem-BM @maryjaf
I updated the success criteria and title.

@mohammadranjbarz
Copy link
Contributor

https://giveth-dapps-v2-git-4732fixstellardoantecardui-givethio.vercel.app/?vercelToolbarCode=rLnDdl4rMPzg2vn

@MoeNick @maryjaf You can test it on preview link

@MoeNick
Copy link
Member

MoeNick commented Sep 15, 2024

@mohammadranjbarz Thank for the PR
the highlighted text should be linked in the red styling and we should remove those buttons in this case. For more context please check the details of the last item in the issue.

image

@maryjaf
Copy link
Collaborator Author

maryjaf commented Sep 15, 2024

https://giveth-dapps-v2-git-4732fixstellardoantecardui-givethio.vercel.app/?vercelToolbarCode=rLnDdl4rMPzg2vn

@MoeNick @maryjaf You can test it on preview link

1-

  • I tap on Donate button
  • in donation page , I tap on "Try donating with stellar"
  • in this page the QF banner is shown and the box related to supported network isn't shown
Screen.Recording.2024-09-15.at.4.23.08.PM.mov

@mohammadranjbarz

@maryjaf
Copy link
Collaborator Author

maryjaf commented Sep 15, 2024

2-
The QF banners should be removed in this page

  • I tap on "donate with stellar"
  • I set an amount
  • and the I tap on next

https://giveth-dapps-v2-git-4732fixstellardoantecardui-givethio.vercel.app/donate/test-stellar?chain=stellar&draft_donation=1233

image


3- This below message also should be removed in stellar donation page

this message for project in a round is shown when user has donated to the project before

image

@maryjaf
Copy link
Collaborator Author

maryjaf commented Sep 15, 2024

4-

The estimated matching, amount raised in round
and also this message "Donate first and lead the way" if project has no donation in a round , shouldn't be shown in stellar donation page
actually the normal view of donation should be shown

image
image

Expected result :
the normal view of donation should be shown in stellar donation page

image

@maryjaf maryjaf moved this from New Issues to In Progress in All-Devs Sep 16, 2024
@Meriem-BM
Copy link
Collaborator

Hey @maryjaf, @MoeNick can you check the remaining issues now
https://giveth-dapps-v2-ghngjaj4f-givethio.vercel.app/

@maryjaf
Copy link
Collaborator Author

maryjaf commented Sep 16, 2024

3- This below message also should be removed in stellar donation page

this message for project in a round is shown when user has donated to the project before

This banner related to QF is still shown in stellar donation page @Meriem-BM

image

@Meriem-BM
Copy link
Collaborator

3- This below message also should be removed in stellar donation page
this message for project in a round is shown when user has donated to the project before

This banner related to QF is still shown in stellar donation page @Meriem-BM

I added a fix @maryjaf https://giveth-dapps-v2-6y5vg6yvh-givethio.vercel.app/

@Meriem-BM
Copy link
Collaborator

#4733 (comment)

@Meriem-BM Meriem-BM moved this from In Progress to QA in All-Devs Sep 16, 2024
@maryjaf
Copy link
Collaborator Author

maryjaf commented Sep 16, 2024

Thanks @Meriem-BM all reported problems have been fixed

@maryjaf maryjaf moved this from QA to Done in All-Devs Sep 16, 2024
@maryjaf maryjaf moved this from Done to Merged to Production in All-Devs Sep 17, 2024
@maryjaf maryjaf closed this as completed by moving to Merged to Production in All-Devs Sep 17, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stellar
Projects
Status: Done
Development

No branches or pull requests

4 participants