Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum up and label recurring donations during GIVbacks rounds in the GIVbacks API #4758

Open
laurenluz opened this issue Sep 19, 2024 · 2 comments
Assignees

Comments

@laurenluz
Copy link
Member

For GIVbacks, donations under $4 are excluded from GIVbacks, but in the case of recurring donations... we should check to see if the total donated throughout the GIVbacks round to that project from a recurring donatino is over $4 - so we need to know the sum of the micro donations to that project from that donor via superfluid in a GIVbacks round.

We would also like to have some indication on if a particular donation total was from a recurring donation sum, or from a regular, one time donation.

cc @WhyldWanderer

@mohammadranjbarz
Copy link
Contributor

@WhyldWanderer @maryjaf It's on staging and is ready for the test

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 29, 2024

I've checked the response of api in different period and with different users, it works as expected
Image

{
"amount": "4.343614922499999",
"currency": "GIV",
"createdAt": "2024-09-26-11:36:19",
"valueUsd": 4.344499999999998,
"anonymous": false,
"bottomRankInRound": 35,
"givbacksRound": 51100,
"projectRank": 22,
"givbackFactor": 0.61470586,
"valueUsdAfterGivbackFactor": 2.6705896,
"giverAddress": "0xa1179f64638adb613ddaac32d918eb6beb824104",
"txHash": "0xa1179f64638adb613ddaac32d918eb6beb824104-0xe6375bc298aeb29d173b2ab359d492439a43b268-0xdfd824f6928b9776c031f7ead948090e2824ce8b-5.0-9.0-1727350578",
"network": "optimism-sepolia",
"source": "giveth.io",
"giverName": "mary jafarimehr",
"giverEmail": null,
"projectLink": "https://giveth.io/project/mejan",
"isReferrerGivbackEligible": false,
"referrerWallet": null,
"numberOfStreamedDonations": 234,
"parentRecurringDonationId": "278",
"parentRecurringDonationTxHash": "0x49ed78ca2c75faa7a43d621f7ed614c1293df3bf9ea7e147acd41f1b0bc30605"
},


Image

{
"amount": "2.830136985",
"currency": "GIV",
"createdAt": "2024-09-29-07:51:44",
"valueUsd": 2.8303,
"anonymous": false,
"bottomRankInRound": 1,
"givbacksRound": 51309,
"projectRank": 1,
"givbackFactor": 0.75,
"valueUsdAfterGivbackFactor": 0,
"giverAddress": "0x7f37e3008207c27360b20abcfb5fdcc8e37596b8",
"txHash": "0x7f37e3008207c27360b20abcfb5fdcc8e37596b8-0xe6375bc298aeb29d173b2ab359d492439a43b268-0xdfd824f6928b9776c031f7ead948090e2824ce8b-1.0-1.0-1727596303",
"network": "optimism-sepolia",
"source": "giveth.io",
"giverName": "maryamaa mehr",
"giverEmail": null,
"projectLink": "https://giveth.io/project/mejan",
"isReferrerGivbackEligible": false,
"referrerWallet": null,
"numberOfStreamedDonations": 21,
"parentRecurringDonationId": "279",
"parentRecurringDonationTxHash": "0x5d41c1bbc6268103fcd6becb6b99396f642a09cd65431fc46ff26e3ddbca40b4"
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants