Dataverse v4.11 facets translation and dataverse-language-packs develop branch

[juancorr]

Dataverse v4.11 facets are not properly translated to French and Spanish. This issue affect to dataverse-language-pack project too. There are some facets that are not translated, other facets with a wrong translation and other that are properly translated:

• "Dataverse Category", "Publication Year" and "Subject" are not translated.
• "Auteur Nom" and "Mot-Clé Terme" should be "Auteur", "Mot-Clé" or "Auteur: Nom", "Mot-Clé: Terme"

This issue is related with IQSS/dataverse#5623 .

[JayanthyChengan]

@juancorr - these were handled in PR IQSS/dataverse#5618 (Still in code review)
also we deployed in production: https://dataverse.scholarsportal.info/dataverse.xhtml

[juancorr]

Thanks @JayanthyChengan . We have used a similar system in e-cienciaDatos : https://github.com/Consorcio-Madrono/dataverse/blob/v4.9.3InternatMadro/src/main/webapp/search-include-fragment.xhtml

I was thought that you would like take out the solr code from the main Bundle . It could be done with the related pull request and a little more code in SearchServiceBean class. Changing the line
facetLabel.setName(facetLabel.getName());
to
facetLabel.setName(getLocaleSolrTitle (facetLabel.getName()));

public String getLocaleSolrTitle(String title) {
    try {
        return BundleUtil.getStringFromPropertyFile(title, "solr");
    } catch (MissingResourceException e) {
        return title;
    }
}

An advantage is to have solr translation entries in a different file.
You can see this code in https://github.com/Consorcio-Madrono/dataverse/blob/v4.11eDatos/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java .

[JayanthyChengan]

Hi @juancorr - As you mentioned, instead of adding keys to bundle.properties and changing search-include-fragment.xhtml , we can go through your approach of creating separate solr.properties file and do changes in SearchServiceBean.java. Did you had a chance to test this approach and verify whether facet search is working fine? Please feel free to give the pull request to IQSS, if you have it ready and so they can review both. Thanks.

[juancorr]

We have a test server in English, French (not completed, only with the develop dataverse-language-packs files) and Spanish: http://oaimadrono.uned.es:8080/

[JayanthyChengan]

@juancorr - I saw your question at http://irclog.iq.harvard.edu/dataverse/2019-03-13#i_87995 .
As a first step, I guess you should add your comments/solution in the corresponding issue - IQSS/dataverse#5207 , where https://github.com/scolapasta will take a look at it. Thanks