Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No graph visualization from examples on codepen.io #144

Open
hoch opened this issue May 3, 2022 · 5 comments
Open

No graph visualization from examples on codepen.io #144

hoch opened this issue May 3, 2022 · 5 comments
Labels

Comments

@hoch
Copy link
Member

hoch commented May 3, 2022

Reproduction:
Visit https://codepen.io/Rumyra/pen/qyMzqN/

Actual:
No graph is visualized.

Expected:
A graph should be visualized.

(This is one of Web Audio demos on MDN)

My suspicion is that DT events are not being fired from an embedded frame.

@hoch hoch added the bug label May 3, 2022
@mzgoddard
Copy link
Collaborator

The iframes on the page probably have a different domain so I think we likely need to expand the extensions permissions.

https://developer.chrome.com/docs/extensions/mv3/declare_permissions/

@mzgoddard
Copy link
Collaborator

The extension manifest is created from a template file https://github.com/GoogleChrome/audion/blob/main/src/build/manifest.json.mustache

@mzgoddard
Copy link
Collaborator

I don't think I thought of this earlier, if it isn't a permission we need to add there may be an additional debugger target for the iframe. The extension attaches to the tab's debugger target. If there is a debugger targets for the iframes too, we may need to additionally attach and enable web audio events for those.

@hoch
Copy link
Member Author

hoch commented May 11, 2022

That sounds like a bit of engineering work then. For now, I can add a short note that the extension doesn't support inspecting iframes.

@hoch
Copy link
Member Author

hoch commented Jun 1, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants