Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Chromium detection in cross platform #278

Open
yhatt opened this issue Sep 9, 2022 · 0 comments
Open

Inconsistent Chromium detection in cross platform #278

yhatt opened this issue Sep 9, 2022 · 0 comments

Comments

@yhatt
Copy link

yhatt commented Sep 9, 2022

In Linux, the current chrome-finder is trying to find out Chromium binary if Google Chrome was not found. (96d5c7c) In contrast, chrome-finder for macOS and Windows is not trying to find Chromium.

A pull request to add Chromium detection for Windows had been rejected (#36), but I feel a bit weird about this inconsistent.

I'm developing a downstream tool that chrome-finder has been integrated, and actually our user is wondering if a lacked Chromium detection in macOS and Windows is bug. (marp-team/marp-cli#475)

I would like to hear the opinion about consistent Chromium detection in cross platform. If you'd like I'll be happy to help for making consistency.

yhatt added a commit to marp-team/marp-cli that referenced this issue Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant