-
Notifications
You must be signed in to change notification settings - Fork 33
Unable to run on JVM 7 #84
Comments
This was a convenience implementation for what we believed would be the most common implementation options. It's probably easy enough to fork this code and make a service that uses the desired timestamp factory. But we could also provide an option or an override for the JodaTimestampFactory. We'll accept pull requests for this, if anyone is interested. |
You mean someone has asked to run the server on JVM 7?
…On 8 Apr 2017 4:41 am, "Erik McClenney" ***@***.***> wrote:
This was a convenience implementation for what we believed would be the
most common implementation options. It's probably easy enough to fork this
code and make a service that uses the desired timestamp factory. But we
could also provide an option or an override for the JodaTimestampFactory.
We'll accept pull requests for this, if anyone is interested.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD61xiemBdoHm1C_lPo-cxuAq0iH8uaks5rtp9fgaJpZM4M2G_5>
.
|
App Engine Standard only supports JVM 7. Can this SDK be used with App Engine Standard? What are the alternatives for implementing custom trace spans for App Engine Standard? |
Ah, I see. App Engine Standard Environment is actually supported through https://github.com/GoogleCloudPlatform/cloud-trace-java/tree/master/services/appengine-standard-service. Just make sure that this dependency is on the classpath at runtime (and none of the other service implementations from https://github.com/GoogleCloudPlatform/cloud-trace-java/tree/master/services is). The gRPC-based client doesn't work in the current App Engine Standard environment. |
Thanks! The README focuses on the gRPC client. So wasn't clear there was another lib for standard. For others who land here: compile group: 'com.google.cloud.trace', name: 'appengine-standard-service', version: '0.3.2' import com.google.cloud.trace.Tracer;
import com.google.cloud.trace.core.TraceContext;
import com.google.cloud.trace.service.AppEngineTraceService;
Tracer tracer = new AppEngineTraceService().getTracer();
TraceContext context = tracer.startSpan("test-span");
// ... code to trace here ...
tracer.endSpan(context); |
In TraceGrpcApiService constructor, it explicitly use JavaTimestampFactory which uses java.time.Instant which is introduced since JDK8 and there is no easy way to replace it with jodaTimestampFactory.
The text was updated successfully, but these errors were encountered: