Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for postponed annotations #292

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support for postponed annotations #292

wants to merge 3 commits into from

Conversation

haizaar
Copy link

@haizaar haizaar commented Nov 30, 2023

Fixes #291

@haizaar
Copy link
Author

haizaar commented Nov 30, 2023

eval_str was added to the signature function only in Python3.10, so this fix is only for 3.10+

@HKWinterhalter
Copy link
Contributor

Thank you for making this fix! Looks like we need three things for this to pass:

  • Python Lint is complaining about format.
  • to pass conventionalcommit, the commit message should be something like "fix: Support for postponed annotations" (i.e. prepend with "fix:")
  • Test coverage

@HKWinterhalter HKWinterhalter removed their assignment Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HKWinterhalter HKWinterhalter HKWinterhalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for postponed annnotations
2 participants
@haizaar @HKWinterhalter