Skip to content

[testing-on-gke part 6.7] Improvements in run script #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 10, 2024
Merged

[testing-on-gke part 6.7] Improvements in run script #2498

merged 29 commits into from
Oct 10, 2024

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Sep 17, 2024 •
edited
Loading

Description

Improvements in run-script:

  • handle pod status 'error'
  • unique AR image-name for each run
  • implement only_parse
  • remove unused code
  • fix package-bucket name
  • improve logs
  • use existing cluster machine-type
  • simplify gcloud auth login
  • pass project-id in gcloud commands
  • Remove need to pass absolute paths
  • support setting gcsfuse_branch for cloning
  • Throw error if exactly one out of project_id and project_number has been set.
  • Improve error logs by adding Error: as prefix.

This is on top of #2497 and is followed up in #2499, #2322, and #2528 .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle mentioned this pull request Sep 17, 2024
Merged
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch 2 times, most recently from 69dd733 to 06df415 Compare September 17, 2024 07:09
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from b77d5ef to bf0661a Compare September 17, 2024 07:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 06df415 to fb05a44 Compare September 17, 2024 10:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch 2 times, most recently from c49f080 to ac9c164 Compare September 17, 2024 10:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from fb05a44 to 2d72ed3 Compare September 17, 2024 10:30
@gargnitingoogle gargnitingoogle marked this pull request as ready for review September 17, 2024 10:37
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners September 17, 2024 10:37
@gargnitingoogle gargnitingoogle requested review from kislaykishore and removed request for a team September 17, 2024 10:37
@gargnitingoogle gargnitingoogle mentioned this pull request Sep 17, 2024
Closed
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from ac9c164 to 4d3d3fb Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 2d72ed3 to b94e91f Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 4d3d3fb to d77db67 Compare September 18, 2024 06:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from b94e91f to 58948ee Compare September 18, 2024 06:53
@gargnitingoogle gargnitingoogle mentioned this pull request Sep 18, 2024
Merged
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from d77db67 to 5825918 Compare September 18, 2024 08:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from b92fa47 to 0364b7c Compare September 18, 2024 08:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 5825918 to ee6d69c Compare September 18, 2024 08:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 0364b7c to 9613a45 Compare September 18, 2024 08:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from ee6d69c to c93fde8 Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 9613a45 to 302395c Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 6.6] Improvements in run script [testing-on-gke part 6.7] Improvements in run script Sep 18, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from c93fde8 to 39ece93 Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 302395c to 5cad921 Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle mentioned this pull request Sep 18, 2024
Merged
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enforce-one-pod-per-node branch from 39ece93 to 5d75bca Compare September 18, 2024 17:19
@gargnitingoogle
implement only_parse
1764157
@gargnitingoogle
unique AR image-name for each run
8b051ac
@gargnitingoogle
handle pod status error
5c87e3d
@gargnitingoogle
make use_custom_csi_driver=true by default
f0c300c
@gargnitingoogle
remove a redundant project_id setting in a gcloud command
c7fd5ed
@gargnitingoogle
Add option to force-update existing gcsfuse code
a47e47a 
Option: force_update_gcsfuse_code
Default: false

This applies when $gcsfuse_src_dir has been passed,
 or when $src_dir/gcsfuse already exists.
@gargnitingoogle
fix implementation of force_fetch_gcsfuse
b3ebf46
@gargnitingoogle
improve debug log
3cd0821
@gargnitingoogle
Add check for missing sudoless-docker
ef58727 
Adds logs for missing sudoless-docker,
helpful instruction to install it,
and then to re-run the script.
@gargnitingoogle
add some error checks in run-script
4107129
@gargnitingoogle
formatting in run-script
7003d85
@gargnitingoogle
Revert "Add project id<->number autoconversion"
4e19a54 
This reverts commit 6fa2ad2.

Reverting this because the above commit exposed PII
in form of the gcsfuse-internal project
IDs and numbers.
@gargnitingoogle
Tie project_id and project_number together
9a57ef3 
The run-gke-tests script should fail
if exactly one out of project_id
and project_number has been set.
It will error out in such as a case.
@gargnitingoogle
Improve error-logs in cli-script
6ba1f06 
Add 'Error: ' prefix in all
the error logs for easy spotting
in log files.
@gargnitingoogle
fix couple of comments
eb717d1
@gargnitingoogle
send all error logs to stderr (fd 2)
0d956bd
@gargnitingoogle
define bash function echoerror
b210bcb
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 3d1dbd7 to b210bcb Compare October 9, 2024 05:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/improvements-in-run-script branch from 747107f to 71db5d8 Compare October 9, 2024 07:43
@kislaykishore kislaykishore requested a review from a team October 9, 2024 07:52
@kislaykishore kislaykishore requested a review from a team October 10, 2024 06:16
@gargnitingoogle gargnitingoogle merged commit d0e543f into master Oct 10, 2024
16 checks passed
@gargnitingoogle gargnitingoogle deleted the garnitin/add-gke-load-testing/improvements-in-run-script branch October 10, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kislaykishore kislaykishore kislaykishore approved these changes

@Tulsishah Tulsishah Awaiting requested review from Tulsishah Tulsishah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gargnitingoogle @kislaykishore