Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Track the Jetty request span in Cloud Trace #201

Open
meltsufin opened this issue Jul 24, 2017 · 4 comments
Open

Track the Jetty request span in Cloud Trace #201

meltsufin opened this issue Jul 24, 2017 · 4 comments

Comments

@meltsufin
Copy link
Member

The span of the request while being processed by Jetty should be reported to Cloud Trace by adding a span to the trace ID found in the x-cloud-trace-context HTTP header.
It should be possible to optionally enable/disable this feature.

@balopat balopat self-assigned this Jul 24, 2017
@meltsufin
Copy link
Member Author

Perhaps use Open Census for this in order to enable tracing for gRPC calls as well: https://github.com/census-instrumentation/opencensus-java/tree/master/exporters/trace_stackdriver#quickstart

@gregw
Copy link
Contributor

gregw commented Sep 6, 2017

Note that for other reasons we are working on adding a new listener to the next jetty 9.4 release that will make it much simpler to track all phases of a request/response life cycle - request line, headers complete, body complete, commit response, response complete.

@meltsufin
Copy link
Member Author

Thanks for the heads of up Greg! It sounds like it would be good place to plug in our tracing.

@gregw
Copy link
Contributor

gregw commented Jan 12, 2018

Note that HttpChannel.Listeners were added in 9.4.8, which should be ideal for this task.

@balopat balopat removed their assignment Sep 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants