Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Jetty io.grpc.internal.AbstractManagedChannelImplBuilder ? #71

Open
gregw opened this issue Nov 17, 2016 · 2 comments
Open

Jetty io.grpc.internal.AbstractManagedChannelImplBuilder ? #71

gregw opened this issue Nov 17, 2016 · 2 comments

Comments

@gregw
Copy link
Contributor

gregw commented Nov 17, 2016

While debugging issues #68 it is clear that:

  • google-cloud-java has lots of dependencies required to implement grpc
  • many of those dependencies (eg netty, httpclient) offer services that are already available in the jetty runtime.
  • grpc is an extensible architecture which appears to support multiple ManagedChannel providers.

Thus there may be significant benefit in providing a Jetty implementation of a grpc channel, which would be able to be used by the session manager, logging and any other google cloud services that will eventually be consumed by the jetty-runtime.

This should allow many dependencies to be removed, a smaller memory foot print and shared resources (eg threadpool) to be used between the client and the server.

@gregw
Copy link
Contributor Author

gregw commented Nov 17, 2016

@meltsufin if this might be at all desirable in the short/mid/long term, could you perhaps put us in touch with somebody from the grpc team to discuss what would be involved?

@meltsufin
Copy link
Member

This sounds like a good idea, but I'm weary of prioritizing it at the moment in light of all the other high-priority work going on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants