Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Create a test for app deployment failure propagation #92

Open
meltsufin opened this issue Dec 13, 2016 · 5 comments
Open

Create a test for app deployment failure propagation #92

meltsufin opened this issue Dec 13, 2016 · 5 comments

Comments

@meltsufin
Copy link
Member

See: #91

@jmcc0nn3ll
Copy link
Contributor

I created a simple test for this here:

https://github.com/GoogleCloudPlatform/jetty-runtime/tree/issue-92

However it doesn't fail based on the current state of master, at least by my reckoning. A badly formatted web.xml should result in the failure of the deployment, right?

@meltsufin
Copy link
Member Author

The scenario I've tested was referencing a non-existing class for a servlet definition in web.xml. That did cause a failure during deployment.

@jmcc0nn3ll
Copy link
Contributor

that works, I'll update the test and look into why the other way wasn't working

@jmcc0nn3ll
Copy link
Contributor

@meltsufin are you still interested in a test like this? it means another maven artifact in tests

@meltsufin
Copy link
Member Author

Sure, another maven artifact could open a whole can of warms with our current test setup though. We'll need to tackle it at some point anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants