Skip to content

Adding in datasource for google_alloydb_instance #12940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 12, 2025
Merged

Adding in datasource for google_alloydb_instance #12940

merged 7 commits into from
Feb 12, 2025

Conversation

NA2047
Copy link
Contributor

@NA2047 NA2047 commented Feb 1, 2025 •
edited
Loading

Adding in a data source for google_alloydb_instance

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_alloydb_instance`

@NA2047 NA2047 marked this pull request as draft February 1, 2025 01:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge February 1, 2025 01:43
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 127 insertions(+))
google-beta provider: Diff ( 3 files changed, 127 insertions(+))

Errors

google provider:

  • The diff processor crashed while computing breaking changes. This is usually due to the downstream provider failing to compile.
  • The diff processor crashed while computing changed resource schemas.

google-beta provider:

  • The diff processor crashed while computing breaking changes. This is usually due to the downstream provider failing to compile.
  • The missing test detector failed to run.
  • The diff processor crashed while computing changed resource schemas.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • alloydb
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccAlloydbDatabaseInstanceDatasourceConfig
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@NA2047 NA2047 force-pushed the alloydbDataSourceInstance branch from 5a80ae0 to 85eb24f Compare February 4, 2025 16:47
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 126 insertions(+))
google-beta provider: Diff ( 3 files changed, 126 insertions(+))

Errors

google provider:

  • The diff processor crashed while computing breaking changes. This is usually due to the downstream provider failing to compile.
  • The diff processor crashed while computing changed resource schemas.

google-beta provider:

  • The diff processor crashed while computing breaking changes. This is usually due to the downstream provider failing to compile.
  • The missing test detector failed to run.
  • The diff processor crashed while computing changed resource schemas.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 123 insertions(+))
google-beta provider: Diff ( 3 files changed, 123 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 73
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbDatabaseInstanceDatasourceConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccAlloydbDatabaseInstanceDatasourceConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@NA2047 NA2047 force-pushed the alloydbDataSourceInstance branch from 0ffe132 to 6a4d947 Compare February 4, 2025 21:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 123 insertions(+))
google-beta provider: Diff ( 3 files changed, 123 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 73
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbDatabaseInstanceDatasourceConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccAlloydbDatabaseInstanceDatasourceConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 157 insertions(+))
google-beta provider: Diff ( 4 files changed, 157 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 73
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbDatabaseInstanceDatasourceConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccAlloydbDatabaseInstanceDatasourceConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 176 insertions(+))
google-beta provider: Diff ( 4 files changed, 176 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 73
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbDatabaseInstanceDatasourceConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccAlloydbDatabaseInstanceDatasourceConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@NA2047 NA2047 force-pushed the alloydbDataSourceInstance branch from 2b13f37 to 9ca97fe Compare February 11, 2025 21:41
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+))
google-beta provider: Diff ( 4 files changed, 194 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+))
google-beta provider: Diff ( 4 files changed, 194 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 73
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbDatabaseInstanceDatasourceConfig

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 73
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbDatabaseInstanceDatasourceConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbDatabaseInstanceDatasourceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbDatabaseInstanceDatasourceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@NA2047 NA2047 marked this pull request as ready for review February 11, 2025 22:39
@NA2047 NA2047 requested review from ScottSuarez and trodge February 11, 2025 22:39
ScottSuarez
ScottSuarez approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval but small nit on code formatting for the provider inventory list

@ScottSuarez ScottSuarez self-requested a review February 11, 2025 23:23
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+))
google-beta provider: Diff ( 4 files changed, 194 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 74
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • alloydb

🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from trodge February 12, 2025 16:58
@NA2047 NA2047 changed the title Adding in data source for google_alloydb_instance Adding in datasource for google_alloydb_instance Feb 12, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 193 insertions(+))
google-beta provider: Diff ( 4 files changed, 193 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 74
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • alloydb

🟢 All tests passed!

View the build log

@ScottSuarez ScottSuarez added this pull request to the merge queue Feb 12, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 2ff0d5c Feb 12, 2025
21 checks passed
This was referenced Feb 12, 2025
Merged
Merged
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
@NA2047 @niharika-98
Adding in datasource for google_alloydb_instance (GoogleCloudPlatform…
9ccfe82 
…#12940)
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
@NA2047 @JaylonmcShan03
Adding in datasource for google_alloydb_instance (GoogleCloudPlatform…
94ddc0f 
…#12940)
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
@NA2047 @JaylonmcShan03
Adding in datasource for google_alloydb_instance (GoogleCloudPlatform…
24316cb 
…#12940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottSuarez ScottSuarez ScottSuarez approved these changes

@trodge trodge Awaiting requested review from trodge

Assignees
No one assigned
Labels
service/alloydb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NA2047 @modular-magician @ScottSuarez @trodge