Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

feat: A high-contrast dark theme #65

Open
1 task done
HubKing opened this issue Nov 12, 2022 · 15 comments
Open
1 task done

feat: A high-contrast dark theme #65

HubKing opened this issue Nov 12, 2022 · 15 comments
Labels
enhancement New feature or request help wanted Extra attention is needed preset request Request a new preset

Comments

@HubKing
Copy link

HubKing commented Nov 12, 2022

Feature description

Dark theme is common these days, but one problem of dark themes is that they often lack contrast. That is, they use light grey text on dark grey background. Or, when they use pure-black background, they lack borders, so UI elements are not discernable. For some users, this lack of contrast is not just a matter of aesthetics, but of accessibility.

Some applications, like JetBrain's IDE or VS Code, have high-contrast dark theme like below. The background is black and the text is white, so they are easy to read, and the UI elements have white borderlines, so they don't look all mingled together.

It seems there is no high-contrast dark theme in the presets, and I failed to make such a theme myself. How about adding a high-contrast dark theme in the presets?

Additional Context

JetBrains' IDE

image

VS Code

image

MS Windows 10

image

Did you read the Code of Conduct?

@HubKing HubKing added the enhancement New feature or request label Nov 12, 2022
@GradienceBot
Copy link
Contributor

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible. You can also join the matrix room https://matrix.to/#/#Gradience-space:envs.net or the discord server https://discord.com/invite/4njFDtfGEZ

@tfuxu tfuxu transferred this issue from GradienceTeam/Gradience Nov 12, 2022
@tfuxu tfuxu added the preset request Request a new preset label Nov 12, 2022
@tfuxu
Copy link
Member

tfuxu commented Nov 12, 2022

Libadwaita (and normal Gtk) applications already have high contrast versions, which you can enable in Accessibility page in GNOME Control Center.
Screenshot from 2022-11-12 12-54-14

@tfuxu tfuxu closed this as completed Nov 12, 2022
@HubKing
Copy link
Author

HubKing commented Nov 13, 2022

Well, it could work for some people, but that is not exactly what I wanted. I am not visually-impaired, I just want black background + white general text, darker background + brighter-coloured text for special elements like buttons, and white borders. If I enable that accessibility feature, it would look like below. The icons look ugly, the background is still grey, not black, and the text is still dim, not white. It also, for some reason, makes some applications use light theme, not dark.

image

@tfuxu
Copy link
Member

tfuxu commented Nov 13, 2022

Well, if you want it ASAP, you can always create it with Gradience and make a PR here with your theme file, so it could be added to our repository for others to download. You can also tell us how this theme should look exactly, and wait until someone from our team or some other interested contributor will create a PR for it.

@tfuxu tfuxu reopened this Nov 13, 2022
@HubKing
Copy link
Author

HubKing commented Nov 18, 2022

@tfuxu No, I do not need it urgently. I had tried to create one, but there were so many entries, so I did not know what exactly each of them were for and could not make a good-looking one. If I changed one thing and then another thing looked bad, and if I fixed that thing, then the previous one looked bad, etc.

@tfuxu
Copy link
Member

tfuxu commented Nov 18, 2022

No, I do not need it urgently.

Alright then, we will create it at some point and notify you when PR will be available, so you could review it.

@tfuxu
Copy link
Member

tfuxu commented Nov 18, 2022

I had tried to create one, but there were so many entries, so I did not know what exactly each of them were for and could not make a good-looking one.

Hmm, we should look into that. Maybe a visual representation (more than just Gradience window changing appearance) could help to understand some color sections.

@daudix daudix added the help wanted Extra attention is needed label Nov 20, 2022
@daudix
Copy link
Member

daudix commented Nov 24, 2022

What about something like this?

high-contrast.zip

@HubKing
Copy link
Author

HubKing commented Nov 26, 2022

What about something like this?

high-contrast.zip

How can I test it? I don't know how to import a ZIP file.

@daudix
Copy link
Member

daudix commented Nov 26, 2022

Unzip it and import .json

@HubKing
Copy link
Author

HubKing commented Nov 26, 2022

Unzip it and import .json

I figured it out, so I was trying to post delete that comment but you have already seen it.

Any way, the high-contrast theme looks good, but I have one question. Does Gnome theme allow customising window borders? I am not sure if it does, but if it does, I think a white window border would be helpful, because currently, when two windows are overlapping, I cannot easily distinguish them.

image

@daudix
Copy link
Member

daudix commented Nov 26, 2022

I think there is option to do so ;)

@tfuxu tfuxu mentioned this issue Nov 28, 2022
6 tasks
@daudix
Copy link
Member

daudix commented Nov 30, 2022

Figured out how to add outlune, looks pretty good

изображение

@HubKing
Copy link
Author

HubKing commented Dec 1, 2022

But how? Are those border lines part of the preset in Gradience, or does it need a third-party tool?

@tfuxu
Copy link
Member

tfuxu commented Dec 1, 2022

Daudix needed to override some CSS rules using Custom CSS editor in Advanced tab to customize window borders, because GTK doesn't expose them directly as @define-color variables. You don't need a third-party tool to do this, but you'll need some knowledge of CSS to customize those more hidden from customization elements in GTK.

@daudix daudix linked a pull request Jan 6, 2023 that will close this issue
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed preset request Request a new preset
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants